refactor(osdtrace): remove BlueStore sub-latencies from output - #173
Merged
Conversation
Simplify print_subop_w and print_op_w output by removing BlueStore sub-stage latencies (prepare, aio_wait, seq_wait, kv_commit) and retaining only the overall bluestore_lat field. Update trace output verification helpers accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR simplifies
osdtraceoutput for write operations (op_wandsubop_w) by removing BlueStore sub-stage latencies (prepare,aio_wait,seq_wait,kv_commit), keeping only the overallbluestore_lat.Changes Included
src/osdtrace.cc: Updatedprint_subop_wandprint_op_wto printbluestore_lat %lldwithout sub-stage parenthetical values.tests/lib/verify-trace-output.sh: Updated log verifier schema, field count assertions, andreadformats to match the simplified row structure.