Skip to content

submit cloud user compatible case:test_user_cloud_compatible.py#34676

Merged
guanshengliang merged 6 commits intomainfrom
cases/TD-6841251930-MAIN
Mar 10, 2026
Merged

submit cloud user compatible case:test_user_cloud_compatible.py#34676
guanshengliang merged 6 commits intomainfrom
cases/TD-6841251930-MAIN

Conversation

@DuanKuanJun
Copy link
Contributor

Description

Issue(s)

  • Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

  • Is the user manual updated?
  • Are the test cases passed and automated?
  • Is there no significant decrease in test coverage?

@DuanKuanJun DuanKuanJun requested a review from a team as a code owner March 4, 2026 08:49
Copilot AI review requested due to automatic review settings March 4, 2026 08:49
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new, extensive test case designed to validate the compatibility and functionality of cloud service users within the TDengine environment. It systematically checks various aspects of user privileges, from basic database and table operations to more complex topic and stream management, as well as information_schema access. The addition ensures that cloud-specific user behaviors and privilege delegations work as expected, including backward compatibility with older privilege syntaxes, thereby enhancing the robustness of user management in cloud deployments.

Highlights

  • New Cloud User Compatibility Test Suite: A comprehensive test suite, test_user_cloud_compatible.py, has been added to verify user creation, privilege management, and data operations within a cloud service context.
  • Extensive Privilege Verification: The new test covers various privilege scenarios, including database-level, super-table level with row-level filtering, topic management (CREATE/SUBSCRIBE/DROP), and stream management (CREATE/SHOW/STOP/DROP) for cloud users.
  • Information Schema and TAOSX Compatibility: Tests are included to ensure correct information_schema access for metadata queries and to simulate taosx data subscription and read query patterns for cloud users.
  • Legacy Privilege Backward Compatibility: The test suite also verifies backward compatibility for legacy GRANT/REVOKE READ/WRITE/ALL syntax on databases and tables, ensuring older privilege models remain functional.
  • CI Integration: The newly added cloud user compatibility test has been integrated into the continuous integration pipeline to ensure ongoing validation of these critical functionalities.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • test/cases/24-Users/test_user_cloud_compatible.py
    • Added a new Python test file for cloud service user compatibility, covering user creation, privilege management, and data operations.
  • test/ci/cases.task
    • Updated the CI task list to include the new test_user_cloud_compatible.py test case.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive new test suite for cloud user compatibility. The test structure is well-organized into individual do_* methods. However, there are several areas for improvement. The file contains future dates in docstrings, an unused import, and inconsistent logging (using print instead of tdLog). There's also a bug in the check_privilege_in_show helper where a parameter is unused, and a duplicated line of code in do_information_schema. Addressing these points will improve the quality and maintainability of the new test file.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new CI test case to validate TDengine Cloud user compatibility, covering user creation, privilege management, subscriptions, streams, and information_schema access.

Changes:

  • Register new cloud compatibility test in CI task list.
  • Add test_user_cloud_compatible.py with end-to-end cloud user privilege/subscription/stream coverage.
  • Include utility helpers for SQL execution/assertions used across sub-tests.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
test/ci/cases.task Adds the new cloud user compatibility test to CI execution list.
test/cases/24-Users/test_user_cloud_compatible.py Introduces a comprehensive cloud user compatibility test suite with setup/teardown and multiple sub-cases.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@guanshengliang guanshengliang merged commit 9402225 into main Mar 10, 2026
20 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants