submit cloud user compatible case:test_user_cloud_compatible.py#34676
submit cloud user compatible case:test_user_cloud_compatible.py#34676guanshengliang merged 6 commits intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new, extensive test case designed to validate the compatibility and functionality of cloud service users within the TDengine environment. It systematically checks various aspects of user privileges, from basic database and table operations to more complex topic and stream management, as well as Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive new test suite for cloud user compatibility. The test structure is well-organized into individual do_* methods. However, there are several areas for improvement. The file contains future dates in docstrings, an unused import, and inconsistent logging (using print instead of tdLog). There's also a bug in the check_privilege_in_show helper where a parameter is unused, and a duplicated line of code in do_information_schema. Addressing these points will improve the quality and maintainability of the new test file.
There was a problem hiding this comment.
Pull request overview
Adds a new CI test case to validate TDengine Cloud user compatibility, covering user creation, privilege management, subscriptions, streams, and information_schema access.
Changes:
- Register new cloud compatibility test in CI task list.
- Add
test_user_cloud_compatible.pywith end-to-end cloud user privilege/subscription/stream coverage. - Include utility helpers for SQL execution/assertions used across sub-tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| test/ci/cases.task | Adds the new cloud user compatibility test to CI execution list. |
| test/cases/24-Users/test_user_cloud_compatible.py | Introduces a comprehensive cloud user compatibility test suite with setup/teardown and multiple sub-cases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Issue(s)
Checklist
Please check the items in the checklist if applicable.