Skip to content

fix(query/mem): release msg memory immediately instead of response#34988

Merged
guanshengliang merged 4 commits intomainfrom
fix/6880911034
Apr 2, 2026
Merged

fix(query/mem): release msg memory immediately instead of response#34988
guanshengliang merged 4 commits intomainfrom
fix/6880911034

Conversation

@stephenkgu
Copy link
Copy Markdown
Contributor

Description

Issue(s)

Checklist

Please check the items in the checklist if applicable.

  • Is the user manual updated?
  • Are the test cases passed and automated?
  • Is there no significant decrease in test coverage?

Copilot AI review requested due to automatic review settings March 30, 2026 06:17
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a memory management improvement in source/libs/qcom/src/queryUtil.c by explicitly freeing pInfo->msgInfo.pData using taosMemoryFreeClear after its contents have been copied to a new buffer. I have no feedback to provide.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses excessive memory retention during async RPC sends by freeing the original request message buffer immediately after it’s copied into the RPC-owned container, rather than holding it until the response/ahandle teardown.

Changes:

  • Free pInfo->msgInfo.pData right after memcpy() into rpcMallocCont() buffer in asyncSendMsgToServerExt.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 31, 2026 01:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@guanshengliang guanshengliang merged commit 3ae0d16 into main Apr 2, 2026
11 of 12 checks passed
@guanshengliang guanshengliang deleted the fix/6880911034 branch April 2, 2026 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants