fix: windows cases failed issues#35014
Conversation
…y three cases failed on windows issues
There was a problem hiding this comment.
Code Review
This pull request adjusts Windows timezone offset calculations to align with POSIX conventions and improves carriage return handling in the shell engine. A critical issue was identified in the test framework where a new return statement prevents the server's running state from being updated, which would cause subsequent operations like stopping the node to fail.
There was a problem hiding this comment.
Pull request overview
Fixes several Windows-specific failures by normalizing CRLF handling, adjusting Windows process start flow in tests, and aligning timezone offset sign conventions.
Changes:
- Strip
\rcleanly when sourcing shell SQL files on Windows. - Prevent
startWithoutSleep()from falling through into non-Windows command execution on Windows. - Negate Windows timezone offsets to match POSIX
tm_gmtoff(east-positive) expectations in timestamp formatting/parsing.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tools/shell/src/shellEngine.c | Changes CR handling when reading sourced SQL lines (CRLF). |
| test/new_test_framework/utils/server/dnode.py | Adjusts Windows start path in startWithoutSleep() to avoid later use of cmd. |
| source/common/src/ttime.c | Fixes Windows timezone offset sign to match POSIX conventions; adds explanatory comments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…y three cases failed on windows issues
Description
Issue(s)
Checklist
Please check the items in the checklist if applicable.