fix: taos_cleanup#35079
Conversation
facetosea
requested review from
a team,
dapan1121 and
guanshengliang
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a minor change to source/libs/qcom/src/queryUtil.c, specifically adding an unnecessary blank line with trailing whitespace inside a conditional block. The feedback correctly identifies this as a violation of code cleanliness standards and recommends its removal.
There was a problem hiding this comment.
Pull request overview
This PR appears to be a temporary/test change set that alters the CI test task list and makes a minor formatting-only tweak in query schema validation code.
Changes:
- Replaces
test/ci/cases.taskwith repeated executions of only three decimal-related pytest cases. - Adds an extra blank/whitespace line in
tIsValidSchema()insource/libs/qcom/src/queryUtil.c.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| test/ci/cases.task | Collapses the CI task matrix down to repeated runs of a small subset of cases (decimal datatype tests). |
| source/libs/qcom/src/queryUtil.c | Formatting-only change (extra blank/whitespace line) inside schema validation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
facetosea
force-pushed
the
fix/test/taoscleanup
branch
from
875a29d to
53e2299
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| return TSDB_CODE_SUCCESS; | ||
| } | ||
|
|
||
| if (timeoutMs >= 0 && remainingMs-- <= 0) { |
There was a problem hiding this comment.
这种计时方法不行，一个循环时间几乎是肯定大于1ms的，甚至严重超过1ms
| clientReqRefPool = -1; | ||
| taosCloseRef(id); | ||
|
|
||
| if (TSDB_CODE_SUCCESS != waitRefSetToBaseCount(clientConnRefPool, "connection", CLIENT_CLEANUP_WAIT_TIMEOUT_MS)) { |
| return; | ||
| } | ||
|
|
||
| if (TSDB_CODE_SUCCESS != waitRefSetToBaseCount(clientReqRefPool, "request", CLIENT_CLEANUP_WAIT_TIMEOUT_MS)) { |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Issue(s)
Checklist
Please check the items in the checklist if applicable.