Skip to content

docs(dotnet): dotnet connector supports decimal data type for stmt#35154

Merged
guanshengliang merged 3 commits intomainfrom
docs/6662861855
Apr 20, 2026
Merged

docs(dotnet): dotnet connector supports decimal data type for stmt#35154
guanshengliang merged 3 commits intomainfrom
docs/6662861855

Conversation

@YamingPei
Copy link
Copy Markdown
Contributor

Description

dotnet connector supports decimal data type for stmt

Issue(s)

Checklist

Please check the items in the checklist if applicable.

  • Is the user manual updated?
  • Are the test cases passed and automated?
  • Is there no significant decrease in test coverage?

Copilot AI review requested due to automatic review settings April 16, 2026 06:58
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the C# connector documentation in both English and Chinese to clarify that the DECIMAL type is not supported as a tag column and to explain its behavior during stmt parameter binding. The review feedback suggests improving punctuation for better readability and adding a warning about potential precision loss when using the C# decimal type for values exceeding 29 digits, recommending the use of strings in such cases.

Comment thread docs/en/14-reference/05-connector/40-csharp.md Outdated
Comment thread docs/en/14-reference/05-connector/40-csharp.md Outdated
Comment thread docs/zh/14-reference/05-connector/40-csharp.mdx Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the C# connector documentation to clarify DECIMAL type limitations and describe new stmt parameter binding support for DECIMAL.

Changes:

  • Document that DECIMAL is not supported as a tag column (ZH/EN).
  • Add DECIMAL stmt parameter binding guidance (supports string and C# decimal, with automatic conversion).
  • Fix/normalize the DECIMAL note formatting in the “Data Type Mapping” section.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
docs/zh/14-reference/05-connector/40-csharp.mdx Updates DECIMAL notes and adds stmt binding guidance for DECIMAL in Chinese docs.
docs/en/14-reference/05-connector/40-csharp.md Updates DECIMAL notes and adds stmt binding guidance for DECIMAL in English docs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/en/14-reference/05-connector/40-csharp.md Outdated
Comment thread docs/en/14-reference/05-connector/40-csharp.md Outdated
Comment thread docs/zh/14-reference/05-connector/40-csharp.mdx
Comment thread docs/zh/14-reference/05-connector/40-csharp.mdx Outdated
Copilot AI review requested due to automatic review settings April 16, 2026 07:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@guanshengliang guanshengliang merged commit b3a72ba into main Apr 20, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants