fix: remove queryBufferSize and cacheLazyLoadThreshold in code and docs#35176
fix: remove queryBufferSize and cacheLazyLoadThreshold in code and docs#35176guanshengliang merged 2 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the documentation for the queryBufferSize configuration parameter across both English and Chinese reference files. The parameter was previously marked as reserved or not yet effective, and its removal ensures the documentation accurately reflects the supported features of the current version. I have no feedback to provide as there were no review comments.
There was a problem hiding this comment.
Pull request overview
Removes documentation references for the queryBufferSize configuration parameter from both English and Chinese component/config reference docs.
Changes:
- Removed
queryBufferSizefrom the config scope comparison tables (EN/ZH). - Removed the detailed
queryBufferSizesection from the Chinesetaosdconfiguration reference. - Removed the
queryBufferSizerow from the Englishtaosdconfiguration table.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| docs/zh/14-reference/01-components/08-config-scope.md | Removes queryBufferSize from the ZH config scope table. |
| docs/zh/14-reference/01-components/01-taosd.md | Removes the ZH detailed queryBufferSize parameter documentation section. |
| docs/en/14-reference/01-components/08-config-scope.md | Removes queryBufferSize from the EN config scope table. |
| docs/en/14-reference/01-components/01-taosd.md | Removes the queryBufferSize row from the EN taosd parameter table. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dapan1121
force-pushed
the
docs/removeQueryBufferSize
branch
from
9aaf270 to
e4c9396
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dapan1121
changed the title
…d configs Both configs were dead code with no actual effect: - queryBufferSize/tsQueryBufferSize/tsQueryBufferSizeBytes: explicitly documented as 'not effective yet'; checkForQueryBuf/releaseQueryBuf were defined but never called anywhere - tsCacheLazyLoadThreshold/cacheLazyLoadThreshold: registered and read from config but never referenced in any business logic Remove variable declarations, definitions, config registrations, config loading, associated functions, cfg file examples, docs, and test entries.
dapan1121
force-pushed
the
docs/removeQueryBufferSize
branch
from
761f73d to
434a92e
Compare
Description
Issue(s)
Checklist
Please check the items in the checklist if applicable.