Skip to content

security and quality: pynacl>=1.6.2#35201

Merged
zitsen merged 1 commit intomainfrom
fix/TD-6714172468-MAIN
Apr 23, 2026
Merged

security and quality: pynacl>=1.6.2#35201
zitsen merged 1 commit intomainfrom
fix/TD-6714172468-MAIN

Conversation

@DuanKuanJun
Copy link
Copy Markdown
Contributor

Description

Issue(s)

  • Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

  • Is the user manual updated?
  • Are the test cases passed and automated?
  • Is there no significant decrease in test coverage?

@DuanKuanJun DuanKuanJun requested a review from a team as a code owner April 22, 2026 06:27
Copilot AI review requested due to automatic review settings April 22, 2026 06:27
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several dependencies in the test/uv.lock file, including major version bumps for cffi and urllib3, and adds pynacl to the test/pyproject.toml dependencies. Feedback was provided regarding an inconsistency where the specific version updates for requests and urllib3 in the lock file are not reflected in test/pyproject.toml, which could lead to synchronization issues.

Comment thread test/uv.lock
Comment on lines +1939 to +1945
{ name = "requests", specifier = "==2.32.4" },
{ name = "taos-ws-py", specifier = ">=0.6.8" },
{ name = "taospy", specifier = ">=2.8.9" },
{ name = "threadpool", specifier = ">=1.3.2" },
{ name = "toml", specifier = ">=0.10.2" },
{ name = "tomli", specifier = "==2.2.1" },
{ name = "urllib3", specifier = "==1.26.20" },
{ name = "urllib3", specifier = "==2.5.0" },
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The specifier values for requests and urllib3 in the lock file have been updated to ==2.32.4 and ==2.5.0 respectively, but these changes are not reflected in the test/pyproject.toml file. This inconsistency will cause uv to report that the lock file is out of sync. Please ensure test/pyproject.toml is updated to match these versions.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the test framework’s Python dependency set to explicitly require a newer PyNaCl version (likely for security/compliance), with the lockfile regenerated accordingly.

Changes:

  • Add pynacl>=1.6.2 to test/pyproject.toml.
  • Regenerate test/uv.lock, updating PyNaCl and multiple resolved/transitive packages and resolution markers.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
test/pyproject.toml Adds an explicit PyNaCl dependency requirement.
test/uv.lock Updates the resolved dependency graph and markers to match the updated requirements.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/pyproject.toml
requires-python = ">=3.9"
dependencies = [
"asyncssh>=2.20.0",
"pynacl>=1.6.2",
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pynacl is added to pyproject.toml, but the documented install path for the test framework uses pip3 install -r requirements.txt (see test/README.md). test/requirements.txt currently doesn't include pynacl, so environments set up per the docs/CI won't actually get this security upgrade. Please either add pynacl>=1.6.2 to test/requirements.txt as well, or update the install instructions/tooling to install from pyproject.toml/uv.lock instead of requirements.txt so dependencies stay in sync.

Copilot uses AI. Check for mistakes.
@zitsen zitsen merged commit a4afef8 into main Apr 23, 2026
11 of 12 checks passed
@zitsen zitsen deleted the fix/TD-6714172468-MAIN branch April 23, 2026 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants