Skip to content

security and quality: urllib3==2.6.3#35204

Merged
zitsen merged 2 commits intomainfrom
fix/TD-6714010571-MAIN
Apr 23, 2026
Merged

security and quality: urllib3==2.6.3#35204
zitsen merged 2 commits intomainfrom
fix/TD-6714010571-MAIN

Conversation

@DuanKuanJun
Copy link
Copy Markdown
Contributor

Description

Issue(s)

  • Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

  • Is the user manual updated?
  • Are the test cases passed and automated?
  • Is there no significant decrease in test coverage?

Copilot AI review requested due to automatic review settings April 22, 2026 07:03
@DuanKuanJun DuanKuanJun requested review from a team, guanshengliang and zitsen as code owners April 22, 2026 07:03
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Python dependency versions to address security/quality concerns, primarily by bumping urllib3 across TDgpt tooling and the test environment.

Changes:

  • Bump urllib3 to 2.6.3 in TDgpt requirements and test project dependencies.
  • Regenerate/update test/uv.lock, which also upgrades additional Python packages (e.g., requests, taos-ws-py, taospy).

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
tools/tdgpt/requirements.txt Pins urllib3==2.6.3 for the TDgpt tool environment.
test/pyproject.toml Pins urllib3==2.6.3 for the test Python project dependencies.
test/uv.lock Updates the locked dependency set to match new pins (and includes additional package upgrades).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several Python dependencies, including major version jumps for urllib3 and requests, and updates to taos-ws-py and taospy. Feedback suggests pinning taospy to an exact version in the test environment for consistency and reproducibility. Additionally, since the taospy update removes pytest-cov as a dependency, it should be explicitly added to the project's dependencies if required by the test suite to prevent CI failures.

Comment thread test/pyproject.toml
Comment thread test/uv.lock
@zitsen zitsen merged commit ee362b0 into main Apr 23, 2026
15 of 16 checks passed
@zitsen zitsen deleted the fix/TD-6714010571-MAIN branch April 23, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants