Skip to content

fix: table columns count over 3000 to save avro error#35338

Merged
guanshengliang merged 3 commits into
3.3.6from
fix/TD-6989427572-3.0
May 15, 2026
Merged

fix: table columns count over 3000 to save avro error#35338
guanshengliang merged 3 commits into
3.3.6from
fix/TD-6989427572-3.0

Conversation

@DuanKuanJun
Copy link
Copy Markdown
Contributor

Description

Issue(s)

  • Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

  • Is the user manual updated?
  • Are the test cases passed and automated?
  • Is there no significant decrease in test coverage?

Copilot AI review requested due to automatic review settings May 14, 2026 09:29
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a manual Avro header writing mechanism to bypass the 64KB schema size limitation in the avro-c library, alongside improvements to NULL handling and data binding for Avro types. Feedback highlights the need to restore buffer_length assignments in TAOS_MULTI_BIND to ensure correct data processing by the TDengine client. Additionally, the reviewer pointed out potential undefined behavior in the zigzag encoding logic and recommended moving srand() out of utility functions to prevent identical sync markers and global state resets.

Comment thread tools/taos-tools/src/taosdump.c
Comment thread tools/taos-tools/src/taosdump.c
Comment thread tools/taos-tools/src/taosdump.c Outdated
Comment thread tools/taos-tools/src/taosdump.c Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates taosdump Avro handling to work around large schema header creation failures and adjusts import handling for nullable binary/bytes fields.

Changes:

  • Adds manual Avro object container header writing for large schemas.
  • Updates Avro dump-in handling for BINARY/NCHAR/BYTES null branches and lengths.
  • Adds a taosdump max-columns case to the parallel test task list.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.

File Description
tools/taos-tools/src/taosdump.c Adds large-schema Avro header workaround and adjusts Avro dump-in binary/bytes null/length handling.
tests/parallel_test/cases.task Adds a new taosdump max-columns test case to parallel testing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tools/taos-tools/src/taosdump.c
Comment thread tools/taos-tools/src/taosdump.c
Comment thread tests/parallel_test/cases.task
Comment thread tools/taos-tools/src/taosdump.c
Copilot AI review requested due to automatic review settings May 14, 2026 11:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

Comment thread tools/taos-tools/src/taosdump.c
Comment thread tests/army/tools/taosdump/native/taosdumpMaxCols.py
Comment thread tools/taos-tools/src/taosdump.c
@guanshengliang guanshengliang merged commit b8c6b3c into 3.3.6 May 15, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants