Add the shared pull-request template (taphouse sync) - #2
Merged
Conversation
Synced from the canonical TapHouse copy: the family's shared review prompts -- what changed and why, a Verification section asking what was actually built and run versus what CI will gate (plus the measured-not-remembered rule for performance claims), and a delete-what-does-not-apply list of the recurring cross-repo concerns: contract changes, submodule pin flow, notebook re-execution, package docs/help and universal binaries, and documented per-repo exceptions. Created only-if-missing and deliberately NOT drift-guarded, following the .claude/settings.json precedent: it is prose for humans rather than a machine-enforced config, so this repo is free to tailor it -- trim the bullets that do not apply here. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JhhQ93r2E1QTnCx46YfX8j
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs the new canonical pull-request template from TapHouse (see tap/TapHouse#5, which adds it to the canonical set and to
scripts/sync.sh). None of the 13 family repos had one.Single file, no code or CI changes.
The template asks for what changed and why, a Verification section stating what was actually built and run versus what CI will gate (plus the family's measured-not-remembered rule for performance claims), and a delete-what-does-not-apply list of the recurring cross-repo concerns.
Most relevant here is the Max package bullet — reference page and help patcher per object, and the macOS binary staying universal. This repo already gates both in CI, and is in fact the only one in the family that runs
cteston both macOS and Windows, plus anotool -L | grep @rpath/libpythoncheck the others have no equivalent for. Those are worth naming in the Verification prompt if you tailor it.It is created only-if-missing and deliberately not drift-guarded, so tailoring it won't fail the drift job.
Three unrelated observations from the sweep that produced this, for whenever this repo is next touched:
@v4while most consumers are on@v5, and carries no.claude/SessionStart hook_testtarget stays at min-api's C++17 and the clang-tidy job is hardcoded to-std=c++17— the only repo in the family without a central C++20 policypackage-info.json.inand the README badges still point attap/Python-Max, the pre-rename identityGenerated by Claude Code