Adopt tap::samplerate namespace and TapHouse v4#38
Merged
Conversation
Bump the drift-check ref v3 -> v4 and add scripts/tidy.sh (the local clang-tidy gate mirror, now distributed by TapHouse). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRTDgYKY38WH8Bqz17W9k1
Aligns SampleRateTap with the tap::<lib> family convention (tap::dsp, tap::ambi, tap::mu, ...). This changes only the C++ namespace: the srt/ include directory, the SampleRateTap CMake target, the SRT_* build options, the srt_* C ABI, and the srt_test test-support namespace are all external contracts and stay as-is (mirroring AmbiTap, which kept ambitap/ + AMBITAP_ + AmbiTap::ambitap under tap::ambi). No back-compat alias — hard rename, no external consumer of the C++ namespace. All 73 tests pass; the C ABI shared library still builds. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRTDgYKY38WH8Bqz17W9k1
tap::samplerate is wider than srt, which shifted clang-format's consecutive-declaration / assignment alignment columns. Reformat with the Tap-wide pinned clang-format (v18.1.3) so the pre-commit gate passes. No functional change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRTDgYKY38WH8Bqz17W9k1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings SampleRateTap in line with the rest of the Tap family.
Namespace:
srt→tap::samplerateAligns the library with the
tap::<lib>convention now shared across thefamily (
tap::dsp,tap::ambi,tap::mu,tap::tools, …). This changesonly the C++ namespace. The external contracts stay exactly as they were,
mirroring how AmbiTap kept
ambitap/+AMBITAP_*+AmbiTap::ambitapwhilemoving to
tap::ambi:include/srt/include directory and#include "srt/…"paths — unchangedSampleRateTap/SampleRateTap::SampleRateTapCMake target — unchangedSRT_*build options — unchangedsrt_*/SRT_*C ABI (tools/capi) — unchangedsrt_testtest-support namespace — unchangedHard rename, no back-compat alias (the C++ namespace has no external
consumer; the C ABI is the external surface and is untouched).
TapHouse v4
Normalizes the shared-style pin and distributes
scripts/tidy.sh, matchingthe rest of the family.
Verification
ctest).-DSRT_BUILD_CAPI=ON).🤖 Generated with Claude Code
https://claude.ai/code/session_01MRTDgYKY38WH8Bqz17W9k1
Generated by Claude Code