Bump the DspTap pin to 28a34a1 - #42
Merged
Merged
Conversation
Refreshes submodules/dsptap from 98abb04 to 28a34a1, the current DspTap main -- two commits: dot_row_reversed (the symmetric-table FIR kernel with its SMLALDX Q15 path) and the shared pull-request template synced from taphouse. The kernel matters here in principle: this repo is where the FIR substrate came from, and dot_row_reversed is the symmetry-halved table kernel RatioTap already consumes. Nothing in this tree calls it yet, so the bump is a no-op functionally; it keeps the pin current so the next substrate change is a small step rather than a large one. Pinned to a commit on DspTap's main rather than any in-flight branch, per the release flow: consumer pins must reference a tree that stays reachable after branch cleanup. Verified: configure and build clean with zero errors, ctest 73/73 passing in Release. Checked before bumping, so this is not a hope: across the whole range every change under DspTap's include/ is an ADDITION -- nine new headers, none modified or deleted -- the exported targets are identical at both ends (tap_dsp_fft, tap::dsp_fft, tap_dsp, tap::dsp, tap_dsp_warnings), and there is no consumer-facing CMake change at all. The one bug fix in the range touched DspTap's own tests/test_kaiser.cpp, not a shipped header. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JhhQ93r2E1QTnCx46YfX8j
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Refreshes
submodules/dsptapfrom98abb04to28a34a1(current DspTapmain) — two commits:dot_row_reversed(the symmetric-table FIR kernel with its SMLALDX Q15 path) and the shared PR template synced from taphouse.Why
The kernel is relevant here in principle: this repo is where the FIR substrate came from, and
dot_row_reversedis the symmetry-halved table kernel RatioTap already consumes. Nothing in this tree calls it yet, so the bump is functionally a no-op — it keeps the pin current so the next substrate change is a small step rather than a large one.Verification
Configure and build clean, zero errors, ctest 73/73 passing in Release.
Checked before bumping:
include/across the range is an addition — 9 new headers, none modified or deletedtap_dsp_fft,tap::dsp_fft,tap_dsp,tap::dsp,tap_dsp_warnings)tests/test_kaiser.cpp, not a shipped headerNotes for the reviewer
Pinned to a commit on DspTap's
mainrather than any in-flight branch, so consumer pins stay reachable after branch cleanup — and independent of tap/DspTap#8.Part of a four-repo sweep (RatioTap, SampleRateTap, TapTools, AmbiTap). MuTap is deliberately excluded: 11 commits behind, but its macOS CI is red from tap/MuTap#31 and a dsptap bump is one of that issue's candidate fixes, so it belongs there rather than in a routine refresh.
Incidental observation from this work, not addressed here: your GTest fetch uses
GIT_REPOSITORY+GIT_TAG, which works behind a restrictive proxy, whereas AmbiTap uses aURLtarball that a proxied container blocks outright. If offline/proxied builds ever matter, the git form is the more robust of the two.Generated by Claude Code