feat: Add logical plan serialization with placeholders in limit - #28
Merged
askalt merged 1 commit intoAug 3, 2026
Merged
Conversation
karpenkoag
force-pushed
the
a.karpenko/limit-placeholder-logical-plan-serialization
branch
2 times, most recently
from
July 20, 2026 09:52
675b3db to
e335efd
Compare
LLDay
self-requested a review
July 24, 2026 11:30
LLDay
reviewed
Jul 27, 2026
karpenkoag
force-pushed
the
a.karpenko/limit-placeholder-logical-plan-serialization
branch
2 times, most recently
from
July 28, 2026 15:37
fa7a01b to
9793b9a
Compare
LLDay
reviewed
Jul 29, 2026
askalt
reviewed
Jul 29, 2026
|
The patch looks as almost done. Suggest to create a PR to the upstream. |
Now the logical plan can be de/serialized if there are placeholders in the limit.
karpenkoag
force-pushed
the
a.karpenko/limit-placeholder-logical-plan-serialization
branch
from
July 31, 2026 12:35
9793b9a to
a820e52
Compare
askalt
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the logical plan can be de/serialized if there are placeholders in the limit.