fixes gh-1036 add opt accept_encoding #1052
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artembo
reviewed
Dec 31, 2019
| and ``Keep-Alive:timeout=<keepalive_idle>``. | ||
| Otherwise Tarantool will send ``Connection:close`` | ||
| * ``low_speed_time`` - set the "low speed time" -- the time that the | ||
| transfer speed should be below the "low speed limit" for the library |
Contributor
veod32
reviewed
Jan 9, 2020
| Setting this option to ``false`` allows to disable this behavior. | ||
| In this case, the HTTP client will return a 3xx response itself. | ||
| * ``accept_encoding`` - enables automatic decompression of HTTP responses | ||
| by setting the contents of the Accept-Encoding header sent in a HTTP |
| In this case, the HTTP client will return a 3xx response itself. | ||
| * ``accept_encoding`` - enables automatic decompression of HTTP responses | ||
| by setting the contents of the Accept-Encoding header sent in a HTTP | ||
| request and enabling decoding of a response when a Content-Encoding |
| by setting the contents of the Accept-Encoding header sent in a HTTP | ||
| request and enabling decoding of a response when a Content-Encoding | ||
| header is received. This option specifies what encoding to use. | ||
| It can be an empty string which means Accept-Encoding header will |
| request and enabling decoding of a response when a Content-Encoding | ||
| header is received. This option specifies what encoding to use. | ||
| It can be an empty string which means Accept-Encoding header will | ||
| contain all built-in supported encodings. It also can be comma-separated |
Collaborator
There was a problem hiding this comment.
all supported built-in encodings
| request and enabling decoding of a response when a Content-Encoding | ||
| header is received. This option specifies what encoding to use. | ||
| It can be an empty string which means Accept-Encoding header will | ||
| contain all built-in supported encodings. It also can be comma-separated |
| header is received. This option specifies what encoding to use. | ||
| It can be an empty string which means Accept-Encoding header will | ||
| contain all built-in supported encodings. It also can be comma-separated | ||
| list of accepted encodings, like: ``"br, gzip, deflate"``. See also |
Collaborator
There was a problem hiding this comment.
- supported encodings? is there any difference between accepted and supported encodings in this context?
- also the question can be what the list is, what encodings are supported. So better to mention all of them here with minimal explanation. Info can be taken from the curl spec (your link below).
- when you give a reference link like 'See also ...', it is better to mention why and for what info you are sending a reader there. Like "For details of the option, refer to..." or "Refer to curl specification for all the details on the option..."
Contributor
There was a problem hiding this comment.
- I guess, no.
gzipanddeflatefor usual build.br(brotli) can be enabled when building from sources against system curl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.