Skip to content

fixes gh-1036 add opt accept_encoding #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Onvember wants to merge 1 commit into from
Closed

fixes gh-1036 add opt accept_encoding #1052

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions doc/reference/reference_lua/http.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,10 +129,10 @@ Below is a list of all ``http`` functions.
* ``keepalive_interval`` - the interval, in seconds, that the operating
system will wait between sending keepalive probes. See also
`CURLOPT_TCP_KEEPINTVL <https://curl.haxx.se/libcurl/c/CURLOPT_TCP_KEEPINTVL.html>`_.
If both keepalive_idle and keepalive_interval are set, then
Tarantool will also set HTTP keepalive headers: Connection:Keep-Alive
and Keep-Alive:timeout=<keepalive_idle>.
Otherwise Tarantool will send Connection:close
If both ``keepalive_idle`` and ``keepalive_interval`` are set, then
Tarantool will also set HTTP keepalive headers: ``Connection:Keep-Alive``
and ``Keep-Alive:timeout=<keepalive_idle>``.
Otherwise Tarantool will send ``Connection:close``
* ``low_speed_time`` - set the "low speed time" -- the time that the
transfer speed should be below the "low speed limit" for the library
Copy link
Contributor

@artembo artembo Dec 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Onvember @veod32 Just for testing gh comments

to consider it too slow and abort. See also
Expand All @@ -158,6 +158,14 @@ Below is a list of all ``http`` functions.
will be received. This last response will be returned as a result.
Setting this option to ``false`` allows to disable this behavior.
In this case, the HTTP client will return a 3xx response itself.
* ``accept_encoding`` - enables automatic decompression of HTTP responses
by setting the contents of the Accept-Encoding header sent in a HTTP
Copy link
Collaborator

@veod32 veod32 Dec 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an HTTP

request and enabling decoding of a response when a Content-Encoding
Copy link
Collaborator

@veod32 veod32 Dec 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the Content-Encoding

header is received. This option specifies what encoding to use.
It can be an empty string which means Accept-Encoding header will
Copy link
Collaborator

@veod32 veod32 Dec 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the Accept-Encoding

contain all built-in supported encodings. It also can be comma-separated
Copy link
Collaborator

@veod32 veod32 Dec 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all supported built-in encodings

Copy link
Collaborator

@veod32 veod32 Dec 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a comma-separated

list of accepted encodings, like: ``"br, gzip, deflate"``. See also
Copy link
Collaborator

@veod32 veod32 Dec 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • supported encodings? is there any difference between accepted and supported encodings in this context?
  • also the question can be what the list is, what encodings are supported. So better to mention all of them here with minimal explanation. Info can be taken from the curl spec (your link below).
  • when you give a reference link like 'See also ...', it is better to mention why and for what info you are sending a reader there. Like "For details of the option, refer to..." or "Refer to curl specification for all the details on the option..."

Copy link
Contributor

@Totktonada Totktonada Jan 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I guess, no.
  2. gzip and deflate for usual build. br (brotli) can be enabled when building from sources against system curl.

`CURLOPT_ACCEPT_ENCODING <https://curl.haxx.se/libcurl/c/CURLOPT_ACCEPT_ENCODING.html>`_

:return: connection information, with all of these components:

Expand Down