Skip to content

tests: replace benchmarks #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 4, 2025
Merged

tests: replace benchmarks #477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
334beab
tests: replace benchmarks
oleg-jukovec Oct 23, 2025
4a259a3
tests: increase initial connect timeout
oleg-jukovec Nov 3, 2025
683d1e4
tests: fix flaky TestFdDialer_Dial_requirements
oleg-jukovec Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions dial_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,8 +658,21 @@ func TestFdDialer_Dial(t *testing.T) {
t.Run(tc.name, func(t *testing.T) {
sock, err := net.Dial("tcp", addr)
require.NoError(t, err)
defer sock.Close()

// It seems that the file descriptor is not always fully ready
// after the connection is created. These lines help to avoid the
// "bad file descriptor" errors.
//
// We already tried to use the SyscallConn(), but it has the same
// issue.
time.Sleep(time.Millisecond)
sock.(*net.TCPConn).SetLinger(0)

f, err := sock.(*net.TCPConn).File()
require.NoError(t, err)
defer f.Close()

dialer := tarantool.FdDialer{
Fd: f.Fd(),
}
Expand All @@ -676,8 +689,21 @@ func TestFdDialer_Dial_requirements(t *testing.T) {

sock, err := net.Dial("tcp", addr)
require.NoError(t, err)
defer sock.Close()

// It seems that the file descriptor is not always fully ready after the
// connection is created. These lines help to avoid the
// "bad file descriptor" errors.
//
// We already tried to use the SyscallConn(), but it has the same
// issue.
time.Sleep(time.Millisecond)
sock.(*net.TCPConn).SetLinger(0)

f, err := sock.(*net.TCPConn).File()
require.NoError(t, err)
defer f.Close()

dialer := tarantool.FdDialer{
Fd: f.Fd(),
RequiredProtocolInfo: tarantool.ProtocolInfo{
Expand All @@ -688,6 +714,7 @@ func TestFdDialer_Dial_requirements(t *testing.T) {
testDialAccept(testDialOpts{}, l)
ctx, cancel := test_helpers.GetConnectContext()
defer cancel()

conn, err := dialer.Dial(ctx, tarantool.DialOpts{})
if err == nil {
conn.Close()
Expand Down
Loading
Loading