driver: fix yield in fifottl/utubettl #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
requested review from
0x501D and
GRISHNOV
and removed request for
GRISHNOV
0x501D
approved these changes
Jun 14, 2023
LeonidVas
requested changes
Jun 14, 2023
Contributor
LeonidVas
left a comment
LeonidVas
left a comment
There was a problem hiding this comment.
Hi! thank you for the patch.
About the title of the commit: "bugfix" not is some subsystem, replace it with something like: "driver: fix yield in fifottl/utubettl".
After 1000 processed tuples an iteration fiber yields after each processed tuple. The problem was fixed by resetting a counter of processed tuples without yield. Closes #208
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-208-too-often-yields
branch
from
0694fc1 to
2392df5
Compare
oleg-jukovec
changed the title
Contributor
Author
Updated. |
LeonidVas
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After 1000 processed tuples an iteration fiber yields after each processed tuple. The problem was fixed by resetting a counter of processed tuples without yield.
Closes #208