[backport 3.3] perf: fix a clang warning for BPS tree perftest#11147
Merged
sergepetrenko merged 1 commit intorelease/3.3from Feb 17, 2025
Merged
[backport 3.3] perf: fix a clang warning for BPS tree perftest#11147sergepetrenko merged 1 commit intorelease/3.3from
sergepetrenko merged 1 commit intorelease/3.3from
Conversation
Clang warned about the getting the offset of a field in a structure with a non-standard layout because of a `std::unique_ptr` field in the `DummyAllocator` class. Let's simply replace it with a regular pointer. Closes #11122 NO_DOC=minor NO_TEST=minor NO_CHANGELOG=minor (cherry picked from commit 0a9258e)
TarantoolBot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This PR is a backport of #11123 to
release/3.3to a future3.3.2release.)Clang warned about the getting the offset of a field in a structure
with a non-standard layout because of a
std::unique_ptrfield inthe
DummyAllocatorclass. Let's simply replace it with a regularpointer.
Closes #11122
NO_DOC=minor
NO_TEST=minor
NO_CHANGELOG=minor