datetime: fix checking timestamp range in new and set#12155
Merged
Buristan merged 1 commit intotarantool:masterfrom Apr 21, 2026
Merged
datetime: fix checking timestamp range in new and set#12155Buristan merged 1 commit intotarantool:masterfrom
Buristan merged 1 commit intotarantool:masterfrom
Conversation
tmr-g
force-pushed
the
i12147
branch
4 times, most recently
from
528462d to
9394677
Compare
tmr-g
force-pushed
the
i12147
branch
2 times, most recently
from
b97c666 to
8552bb7
Compare
tmr-g
changed the title
xuniq
approved these changes
Dec 23, 2025
tmr-g
force-pushed
the
i12147
branch
3 times, most recently
from
9542ee7 to
f458d1b
Compare
ligurio
reviewed
Jan 16, 2026
Member
ligurio
left a comment
ligurio
left a comment
There was a problem hiding this comment.
Thanks for the patch! In general everything is good, let's make some changes, see my comments.
ligurio
reviewed
Mar 13, 2026
ligurio
reviewed
Mar 13, 2026
tmr-g
force-pushed
the
i12147
branch
7 times, most recently
from
f9f2a52 to
6d43487
Compare
tmr-g
force-pushed
the
i12147
branch
2 times, most recently
from
a39432f to
b6e6b58
Compare
ligurio
reviewed
Apr 9, 2026
Member
ligurio
left a comment
ligurio
left a comment
There was a problem hiding this comment.
Jenya, thanks for the patch! LGTM with two minor comments inline.
ligurio
approved these changes
Apr 9, 2026
Now `datetime.new()` and `datetime_object:set()` check timestamp value to be in valid range. Out of range timestamps produce an error instead of assertion failure. Fixes tarantool#12147 NO_DOC=bugfix
tmr-g
added
backport/2.11
Collaborator
|
Successfully created backport PR for |
Collaborator
|
Successfully created backport PR for |
Collaborator
|
Successfully created backport PR for |
Collaborator
|
Successfully created backport PR for |
Collaborator
|
Successfully created backport PR for |
Collaborator
Backport summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now
datetime.new()anddatetime_object:set()check timestamp value to be in valid range.
Out of range timestamps produce an error instead of assertion failure.
Fixes #12147
Waits for #12423 and it's backports #12549 #12550 #12551 #12552 #12553 to be merged.