You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The review system still carries .reviews/components/Show.md, and seven
operational review documents use it for conditional output. Executable.md now
has the native structural <If> directive, so this local standard-library
component duplicates engine behavior and lets the operational documents drift
from the documented language.
The original release dependency is obsolete. .github/workflows/review.yml
prepares and builds the checked-out revision and runs ./dist/xmd; it no longer
installs the latest published binary. <If> is also present in v0.7.0.
Scope
Replace Show directly with If in these seven documents:
.reviews/components/CommentReview.md
.reviews/components/Finding.md
.reviews/components/OxlintSummary.md
.reviews/components/ReleaseSpecWarning.md
.reviews/components/UnusedInDiff.md
.reviews/policies/ExtraneousCodePolicy.md
.reviews/policies/RepoCleanupPolicy.md
For each block, rename when to condition and preserve its body and authored
whitespace. The current expressions already produce booleans. None has a
fallback, so no <Else> is needed.
Also:
delete .reviews/components/Show.md;
remove the Show.md fixture copy from packages/core/tests/unused-in-diff.test.ts;
update the stale Show wording and example in specs/code-review-agent-spec.md; and
add review-infrastructure regressions that execute the migrated operational
documents and prove native <If> resolution, selected/suppressed output,
and non-execution of a false branch.
Acceptance
No Show tag or .reviews/components/Show.md remains in .reviews/.
No focused test fixture or code-review specification claim still treats Show as part of the review component library.
The migrated documents resolve built-in <If> without a Show or If
component stub.
UnusedInDiff preserves both its rendered disclosure/table and its empty
suppressed output.
Review-infrastructure tests execute all seven migrated documents without an ERROR marker and prove that an unselected branch does not reach Sample.
Compact selected and suppressed outputs retain their existing whitespace and
visible text.
When local review credentials and a model are available, a credentialed local
review is recorded as integration evidence. Missing credentials or model
availability skips that evidence; it is not a local test failure.
The PR's checked-out-source review workflow posts its substantive review
comment without an ERROR marker before merge.
Problem
The review system still carries
.reviews/components/Show.md, and sevenoperational review documents use it for conditional output. Executable.md now
has the native structural
<If>directive, so this local standard-librarycomponent duplicates engine behavior and lets the operational documents drift
from the documented language.
The original release dependency is obsolete.
.github/workflows/review.ymlprepares and builds the checked-out revision and runs
./dist/xmd; it no longerinstalls the latest published binary.
<If>is also present in v0.7.0.Scope
Replace
Showdirectly withIfin these seven documents:.reviews/components/CommentReview.md.reviews/components/Finding.md.reviews/components/OxlintSummary.md.reviews/components/ReleaseSpecWarning.md.reviews/components/UnusedInDiff.md.reviews/policies/ExtraneousCodePolicy.md.reviews/policies/RepoCleanupPolicy.mdFor each block, rename
whentoconditionand preserve its body and authoredwhitespace. The current expressions already produce booleans. None has a
fallback, so no
<Else>is needed.Also:
.reviews/components/Show.md;Show.mdfixture copy frompackages/core/tests/unused-in-diff.test.ts;Showwording and example inspecs/code-review-agent-spec.md; anddocuments and prove native
<If>resolution, selected/suppressed output,and non-execution of a false branch.
Acceptance
Showtag or.reviews/components/Show.mdremains in.reviews/.Showas part of the review component library.<If>without aShoworIfcomponent stub.
UnusedInDiffpreserves both its rendered disclosure/table and its emptysuppressed output.
ERRORmarker and prove that an unselected branch does not reachSample.visible text.
review is recorded as integration evidence. Missing credentials or model
availability skips that evidence; it is not a local test failure.
comment without an
ERRORmarker before merge.Out of scope
<If>or<Else>syntax, validation, evaluation, or truthinesssemantics, including issue Coerce the <If> condition with JS truthiness #258
.github/workflows/review.ymlor any other workflowShowmerely as an arbitrarycomponent name