This repository was archived by the owner on Jul 16, 2024. It is now read-only.
removed encoding on fields in source docs#78
Merged
abstract-base-method merged 2 commits intotarget:masterfrom May 10, 2018
Merged
removed encoding on fields in source docs#78abstract-base-method merged 2 commits intotarget:masterfrom
abstract-base-method merged 2 commits intotarget:masterfrom
Conversation
…ng rescheduling, and is only used in the daemon, which does type checking
dgund14
previously approved these changes
May 9, 2018
abstract-base-method
approved these changes
May 9, 2018
abstract-base-method
suggested changes
May 9, 2018
Collaborator
abstract-base-method
left a comment
abstract-base-method
left a comment
There was a problem hiding this comment.
@chollinger please increment the minor version number to trigger a PyPi release
abstract-base-method
approved these changes
May 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GREASE Developer Pull Request Checklist removed encoding on fields in source docs
USE THIS TEMPLATE FOR YOUR PULL REQUEST!
Purpose
This encoding was causing it to be deserialized as
bytes, which was causing issues during rescheduling. These fields are only used in the daemon, which does type checking, so it will not affect anything else.Expected Outcome
Rescheduling doesn't give garbage config names.
Checklist