Skip to content

chore(server): remove obsolete migration repair - #113

Merged
tarik02 merged 1 commit into
mainfrom
chore/remove-obsolete-migration-repair
Aug 4, 2026
Merged

chore(server): remove obsolete migration repair#113
tarik02 merged 1 commit into
mainfrom
chore/remove-obsolete-migration-repair

Conversation

@tarik02

@tarik02 tarik02 commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

What Changed

Removed the startup repair that deleted the legacy ProjectionThreadGoals entry from the main database migration ledger.

Why

All fork databases have completed the one-time migration. Rewriting the ledger on every startup is no longer needed, so startup can go straight to the standard migration runner.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Model: gpt-5.6-sol
Harness: T3 Code

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S labels Aug 4, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f9e8d17254

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

if (!trial) {
yield* sql`PRAGMA journal_mode = WAL;`;
yield* repairMainMigrationLedger();
yield* runMigrations();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve the ledger repair for dormant fork upgrades

Keep the repair for users upgrading directly from fork version 0.0.24, whose main ledger can end at migration 31 named ProjectionThreadGoals. The Effect migrator only runs IDs greater than the latest recorded ID, so this direct call skips the current migration 31 (AuthAuthorizationScopes) and proceeds with the old role-based auth tables intact; current pairing and session queries then access missing scopes columns and break authentication. A distributed fork cannot assume every dormant installation has already passed through an intermediate repairing release.

AGENTS.md reference: AGENTS.md:L13-L15

Useful? React with 👍 / 👎.

@tarik02
tarik02 merged commit e88b1c8 into main Aug 4, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant