Skip to content

Fix for #121 download attachments using API access key#202

Merged
alexeyOnGitHub merged 3 commits intotaskadapter:masterfrom
keritaf:fix/download-attachments-api-key
Nov 12, 2015
Merged

Fix for #121 download attachments using API access key#202
alexeyOnGitHub merged 3 commits intotaskadapter:masterfrom
keritaf:fix/download-attachments-api-key

Conversation

@keritaf
Copy link
Copy Markdown
Contributor

@keritaf keritaf commented Jun 22, 2015

Fixes #121

@keritaf keritaf mentioned this pull request Jun 22, 2015
Closed
@alexeyOnGitHub
Copy link
Copy Markdown
Member

alexeyOnGitHub commented Jul 7, 2015

how did you test this? I don't see any tests

@keritaf
Copy link
Copy Markdown
Contributor Author

keritaf commented Jul 7, 2015

Almost same problem as with project custom fields in #201 - you can't actually create an attachment using Redmine REST API. Added integration test stub for the API key authentication case.

@alexeyOnGitHub alexeyOnGitHub added this to the 2.5.0 milestone Oct 16, 2015
@alexeyOnGitHub alexeyOnGitHub changed the title Fix variant for #121 Fix for #121 download attachments using API access key Oct 16, 2015
@alexeyOnGitHub
Copy link
Copy Markdown
Member

alexeyOnGitHub commented Oct 16, 2015

I'm getting this error when running your test:

com.taskadapter.redmineapi.RedmineInternalError: Unsupported class class com.taskadapter.redmineapi.bean.Attachment
at com.taskadapter.redmineapi.internal.Transport.getConfig(Transport.java:610)
at com.taskadapter.redmineapi.internal.Transport.getObject(Transport.java:329)
at com.taskadapter.redmineapi.internal.Transport.getObject(Transport.java:395)
at com.taskadapter.redmineapi.AttachmentManager.getAttachmentById(AttachmentManager.java:158)
at com.taskadapter.redmineapi.AttachmentIntegrationTest.testDownloadAttachmentContentWithAPIKey(AttachmentIntegrationTest.java:181)

@alexeyOnGitHub alexeyOnGitHub modified the milestones: 2.6.0, 2.5.0 Oct 17, 2015
@alexeyOnGitHub
Copy link
Copy Markdown
Member

alexeyOnGitHub commented Oct 19, 2015

I merged a fix for "unsupported class" to "master".

alexeyOnGitHub added a commit that referenced this pull request Nov 12, 2015
@alexeyOnGitHub
Merge pull request #202 from keritaf/fix/download-attachments-api-key
69c14bc 
Fix for #121  download attachments using API access key
@alexeyOnGitHub alexeyOnGitHub merged commit 69c14bc into taskadapter:master Nov 12, 2015
@alexeyOnGitHub
Copy link
Copy Markdown
Member

alexeyOnGitHub commented Nov 12, 2015

thank you, @keritaf

@alexeyOnGitHub alexeyOnGitHub added this to the 2.7.0 milestone Nov 12, 2015
@alexeyOnGitHub alexeyOnGitHub modified the milestones: 3.0.0, 2.7.0 Jul 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@keritaf @alexeyOnGitHub