Guard against unregistered task in before_task_publish handler - #57
Merged
Conversation
celery.current_app.tasks.get(sender) can return None when the publishing process hasn't imported the task, crashing update_state(). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
snopoke
marked this pull request as ready for review
July 27, 2026 13:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before_task_publishfires wherever.delay()/.apply_async()is called, which can be a producer process that hasn't imported the task module. In that casecelery.current_app.tasks.get(sender)returnsNone, and the unconditionalctask.update_state(...)call crashed withAttributeError: 'NoneType' object has no attribute 'update_state'.TaskBadger task creation still happens via
create_task_safe; only the local Celery state update is skipped when the task class isn't registered.