Skip to content
This repository was archived by the owner on May 9, 2020. It is now read-only.

Comments

Bug 1490964 - tighten docker-worker payload schema#409

Merged
walac merged 1 commit intomasterfrom
bug1490964
Sep 13, 2018
Merged

Bug 1490964 - tighten docker-worker payload schema#409
walac merged 1 commit intomasterfrom
bug1490964

Conversation

@petemoore
Copy link
Member

@petemoore petemoore commented Sep 13, 2018

This tightens the screws on the payload schema of docker-worker primarily by adding additionalProperties settings throughout the JSON subschemas.

This is useful for two reasons:

  1. Currently additional properties can be submitted without causing a malformed payload exception, that would be ignored by docker-worker (e.g. misspelled properties) and would cause hard-to-diagnose failures for task submitters
  2. It causes cleaner types to be generated by github.com/taskcluster/jsonschema2go which will simplify and improve the process of adding support for docker-worker payloads in generic-worker

See bug 1490964 for further context.

@petemoore petemoore requested a review from walac September 13, 2018 11:13
@petemoore petemoore self-assigned this Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants