Bug 1488148: Add localhost.localdomain host name#411
Bug 1488148: Add localhost.localdomain host name#411walac merged 3 commits intotaskcluster:masterfrom
Conversation
walac
force-pushed
the
master
branch
3 times, most recently
from
4b07a36 to
36bdf4e
Compare
djmitche
left a comment
djmitche
left a comment
There was a problem hiding this comment.
Approved if the schemas/payload.json change is removed..
| "properties": { | ||
| "log": { | ||
| "title": "Custom log location", | ||
| "type": "string" |
There was a problem hiding this comment.
I don't see any changes to actually use this value -- was this diff included by mistake?
If not, a description property would be great: What does this mean? Is it a path on the host or in the docker container? Or is it the artifact name?
There was a problem hiding this comment.
This is part of unit tests fixes broken in #409
There was a problem hiding this comment.
Ah, ok -- could you add the description then? I didn't know such a thing was available (I still don't!)
There was a problem hiding this comment.
Neither do I before the tests started to fail.
| ShmSize: 1800000000, | ||
| ExtraHosts: [ | ||
| 'localhost.localdomain:127.0.0.1', // for nss-try | ||
| ], |
There was a problem hiding this comment.
This seems like the critical change, and seems fine (maybe link to the bug instead of just saying it's for nss-try? It seems pretty generic and other projects might want the functionality too)
* Fix payloads with extra fields * Fix expired task artifact download
This test was never reliable. Let's trust in the unit tests to make sure upload retry works.
This is a requirement for nss-try. We could work on allowing additional configuration from the VM using the user data, but as we aim to replace docker-worker, lets postpone more elaborate configs for newer worker.
2 participants
This is a requirement for nss-try. We could work on allowing additional
configuration from the VM using the user data, but as we aim to replace
docker-worker, lets postpone more elaborate configs for newer worker.