Updated tests - #34
Merged
Merged
Conversation
# Conflicts: # tests/FileManager.UiTests/FileOperationUiTests.cs # tests/FileManager.UiTests/Infrastructure/FileOperationUiTestBase.cs # tests/FileManager.UiTests/Infrastructure/NativeCommands.cs # tests/FileManager.UiTests/NativeSafetyRegressionTests.cs # tests/FileManager.UiTests/obj/FileManager.UiTests.csproj.nuget.dgspec.json # tests/FileManager.UiTests/obj/FileManager.UiTests.csproj.nuget.g.props # tests/FileManager.UiTests/obj/project.assets.json # tests/FileManager.UiTests/obj/project.nuget.cache
mzagozda
previously requested changes
Aug 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates test tooling and documentation around the FileManager UI test suite, along with small build/test harness adjustments and a minor C++ compile fix.
Changes:
- Adds a repository-root
run-ui-tests.ps1wrapper to standardize running the UI test project and safely set required environment variables. - Updates
tests/FileManager.UiTests/README.mdto describe the new runner and current test categories/counts. - Adjusts the bzip2 compatibility probe build flags and adds a C++ no-op statement to satisfy a label/statement requirement.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/test-bzip2-compatibility.ps1 | Updates MSVC warning suppressions and clarifies rationale for upstream diagnostics. |
| tests/FileManager.UiTests/README.md | Documents the runner script, categories, and recommended execution flows for UI tests. |
| src/async_copy.cpp | Adds an explicit empty statement after a label to keep compilation valid when deletion is skipped. |
| run-ui-tests.ps1 | Introduces a PowerShell entry point for running UI tests with environment gating and executable path resolution. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mzagozda
self-requested a review
August 21, 2026 06:20
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
mzagozda
approved these changes
Aug 21, 2026
Contributor
|
@PatrykLs98 approved. Please check if you can merge and take it to the main branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.