Improve formatnum parserfn#424
Merged
Merged
Conversation
This does not implement "alternative" digits, like in South Asian scripts or West Arabic Numerals, because I didn't find a good authorative way to do it in Python. In the current version of Python, there *SHOULD BE*, but isn't because it's bugged. locale.ALT_DIGITS data (well locale.ALT_DIGITS is a flag that is used to get the data from somewhere else...) is broken, and even if it was broken it contains weird data (the first 0..99 ways to write positive integers in that script), which doesn't tell us whether the localization should use those alternative digits when doing number localization... This needs to be checked later in a later version of Python, but the whole locale module stuff is just weird stuff inherited from Posix and C.
kristian-clausal
force-pushed
the
formatnum
branch
from
11b1f05 to
ba36b4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #423
Improvements to formatnum:
R"reverse" flag that converts from "formatted" to "raw". Basically it removes commas at its simplest.I'll look into localization later in this draft.