Skip to content

fix: platform check on set_show_menu_on_left_click#11797

Closed
sandercox wants to merge 1 commit intotauri-apps:devfrom
sandercox:fix-tray-icon-windows
Closed

fix: platform check on set_show_menu_on_left_click#11797
sandercox wants to merge 1 commit intotauri-apps:devfrom
sandercox:fix-tray-icon-windows

Conversation

@sandercox
Copy link
Copy Markdown
Contributor

The platform check was broken after a merge I'm afraid. It needs to spell out target_os in the check.

This is regression caused by changes in #11726 compared to the changes merged from #11729.

The platform check was broken after a merge I'm afraid. It needs
to spell out `target_os` in the check.
@sandercox sandercox requested a review from a team as a code owner November 26, 2024 13:36
@github-actions
Copy link
Copy Markdown
Contributor

Package Changes Through 2d25e89

There are 8 changes which include @tauri-apps/api with minor, tauri-bundler with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.1.1 2.2.0
tauri-utils 2.1.0 2.1.1
tauri-bundler 2.1.0 2.2.0
tauri-runtime 2.2.0 2.3.0
tauri-runtime-wry 2.2.0 2.3.0
tauri-codegen 2.0.3 2.0.4
tauri-macros 2.0.3 2.0.4
tauri-plugin 2.0.3 2.0.4
tauri-build 2.0.3 2.0.4
tauri 2.1.1 2.2.0
@tauri-apps/cli 2.1.0 2.2.0
tauri-cli 2.1.0 2.2.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@FabianLars
Copy link
Copy Markdown
Member

windows is a shortcut for target_family = "windows" and should work. (there's another unix shortcut but that includes macos and linux so we don't use it often)

@sandercox
Copy link
Copy Markdown
Contributor Author

Right... I would swear I had issues that went away with changing this but changing it back now it's still all ok. Sorry for my lack of knowledge here.

@sandercox sandercox closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants