Skip to content

chore(deps): wry@0.50 muda@0.16 tray-icon@0.20 windows@0.60 webview2-com@0.36 objc@0.6 window-vibrancy@0.6 tao@0.32 #12541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 25, 2025
Merged

chore(deps): wry@0.50 muda@0.16 tray-icon@0.20 windows@0.60 webview2-com@0.36 objc@0.6 window-vibrancy@0.6 tao@0.32 #12541

merged 9 commits into from
Feb 25, 2025

Conversation

FabianLars
Copy link
Member

No description provided.

@FabianLars FabianLars requested a review from amrbashir January 27, 2025 19:28
@FabianLars FabianLars requested a review from a team as a code owner January 27, 2025 19:28
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 27, 2025 •
edited
Loading

Package Changes Through 04f2b20

There are 9 changes which include tauri-cli with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with minor, tauri with minor, @tauri-apps/api with minor, @tauri-apps/cli with minor, tauri-bundler with patch, tauri-macos-sign with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.2.0 2.3.0
tauri-utils 2.1.1 2.2.0
tauri-macos-sign 2.0.1 2.1.0
tauri-bundler 2.2.3 2.2.4
tauri-runtime 2.3.0 2.4.0
tauri-runtime-wry 2.3.0 2.4.0
tauri-codegen 2.0.4 2.0.5
tauri-macros 2.0.4 2.0.5
tauri-plugin 2.0.4 2.0.5
tauri-build 2.0.5 2.0.6
tauri 2.2.5 2.3.0
@tauri-apps/cli 2.2.7 2.3.0
tauri-cli 2.2.7 2.3.0

Add another change file through the GitHub UI by following this link.

Read about change files or the docs at github.com/jbolda/covector

FabianLars
FabianLars commented Jan 27, 2025
View reviewed changes
crates/tauri-runtime-wry/src/undecorated_resizing.rs
GetModuleHandleW(PCWSTR::null()).unwrap_or_default(),
Some(parent),
None,
GetModuleHandleW(None).ok().map(|h| HINSTANCE(h.0)),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is weirding me out a bit

@FabianLars

This comment was marked as resolved.

Sign in to view
@FabianLars FabianLars changed the title chore(deps): Update windows to 0.59. Update webview2-com to 0.35 chore(deps): wry@0.49 muda@0.16 tray-icon@0.20 windows@0.59 webview2-com@0.35 objc@0.6 Feb 21, 2025
@FabianLars FabianLars changed the title chore(deps): wry@0.49 muda@0.16 tray-icon@0.20 windows@0.59 webview2-com@0.35 objc@0.6 chore(deps): wry@0.49 muda@0.16 tray-icon@0.20 windows@0.59 webview2-com@0.35 objc@0.6 window-vibrancy@0.6.0 Feb 21, 2025
lucasfernog
lucasfernog previously approved these changes Feb 21, 2025
View reviewed changes
@FabianLars
Copy link
Member Author

will fix the build error as soon as Windows Defender stops throwing a tantrum

@Legend-Master
Copy link
Contributor

I think we should also update tao here? (need to release the new version of tao first)

@FabianLars
Copy link
Member Author

i knew i forgot something

@FabianLars
Copy link
Member Author

okay this will take a bit. didn't see that i was pinged in tao's objc2 PR - will look at it right away

@Legend-Master
Copy link
Contributor

Well, windows-rs just dropped an update moment ago 😂
https://github.com/microsoft/windows-rs/releases/tag/0.62.0

@FabianLars
Copy link
Member Author

FabianLars commented Feb 21, 2025 •
edited
Loading

i'll pretend i didn't see it

@FabianLars
Copy link
Member Author

jokes aside, i won't address that in this PR, maybe not even in 2.3.0 - that looks kinda big

@FabianLars FabianLars changed the title chore(deps): wry@0.49 muda@0.16 tray-icon@0.20 windows@0.59 webview2-com@0.35 objc@0.6 window-vibrancy@0.6.0 chore(deps): wry@0.49 muda@0.16 tray-icon@0.20 windows@0.59 webview2-com@0.35 objc@0.6 window-vibrancy@0.6 tao@0.32 Feb 21, 2025
@Legend-Master
Copy link
Contributor

Legend-Master commented Feb 22, 2025 •
edited
Loading

windows 0.60 didn't change much and shouldn't take very long, I'll try getting it updated in tao, webview2 and wry

@Legend-Master
Copy link
Contributor

Not 100% sure but I think we might need to adjust the undercoated window resizing code as well because of the change we made in tauri-apps/tao#1052

@lucasfernog lucasfernog mentioned this pull request Feb 24, 2025
Closed
@FabianLars FabianLars marked this pull request as draft February 24, 2025 13:49
@FabianLars FabianLars changed the title chore(deps): wry@0.49 muda@0.16 tray-icon@0.20 windows@0.59 webview2-com@0.35 objc@0.6 window-vibrancy@0.6 tao@0.32 chore(deps): wry@0.50 muda@0.16 tray-icon@0.20 windows@0.60 webview2-com@0.36 objc@0.6 window-vibrancy@0.6 tao@0.32 Feb 25, 2025
@FabianLars
Copy link
Member Author

Not 100% sure but I think we might need to adjust the undercoated window resizing code as well because of the change we made in tauri-apps/tao#1052

(according to lucas) resizing still works so imo we can merge this and check if we need/should adapt these changes in a later PR / release as well. (tbh, i'm just super out of the loop on the resizing stuff so this probably needs @amrbashir input)

@FabianLars FabianLars marked this pull request as ready for review February 25, 2025 17:34
lucasfernog
lucasfernog approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I'm testing this with an actual app
but I've also asked Amr to double check

@amrbashir
Copy link
Member

Let's merge this and I will improve the undecorated resizing in a different PR.

@amrbashir amrbashir merged commit d6520a2 into dev Feb 25, 2025
27 checks passed
@amrbashir amrbashir deleted the deps/windows059 branch February 25, 2025 17:41
@github-actions github-actions bot mentioned this pull request Feb 25, 2025
Merged
@lucasfernog lucasfernog mentioned this pull request Feb 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

@amrbashir amrbashir Awaiting requested review from amrbashir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FabianLars @Legend-Master @amrbashir @lucasfernog