Skip to content

fix(cli): respect src/bin required-features (fix: #15325)#15427

Open
puneetdixit200 wants to merge 1 commit into
tauri-apps:devfrom
puneetdixit200:fix/15325-required-features-src-bin
Open

fix(cli): respect src/bin required-features (fix: #15325)#15427
puneetdixit200 wants to merge 1 commit into
tauri-apps:devfrom
puneetdixit200:fix/15325-required-features-src-bin

Conversation

@puneetdixit200
Copy link
Copy Markdown

Summary

Fixes #15325.

get_binaries already skips Cargo [[bin]] targets when their required-features are not enabled. The later src/bin scan did not know about those skipped manifest targets and added them back by filename.

This keeps track of disabled manifest bins and skips matching src/bin entries, while still including them when the feature is enabled.

Tests

  • cargo test --manifest-path crates/tauri-cli/Cargo.toml get_binaries_ignores_src_bin_with_disabled_required_features -- --nocapture
  • cargo test --manifest-path crates/tauri-cli/Cargo.toml
  • cargo clippy --manifest-path crates/tauri-cli/Cargo.toml --all-targets --all-features -- -D warnings -A clippy::while_let_loop
  • node .scripts/ci/check-change-tags.js .changes/cli-required-features-src-bin.md
  • git diff --check

Note: local Clippy 1.95 reports an existing while_let_loop lint in helpers/pbxproj.rs without that targeted allow.

@puneetdixit200 puneetdixit200 requested a review from a team as a code owner May 21, 2026 23:28
@github-actions
Copy link
Copy Markdown
Contributor

Package Changes Through a975472

There are 2 changes which include tauri-cli with patch, tauri-bundler with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-bundler 2.9.2 2.9.3
@tauri-apps/cli 2.11.2 2.11.3
tauri-cli 2.11.2 2.11.3

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Copy link
Copy Markdown
Contributor

@Legend-Master Legend-Master left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Also you'll need to sign your commits for me to merge this

https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] tauri-bundler stage-2 src/bin/ disk scan ignores [[bin]] required-features

2 participants