fix(cli): respect src/bin required-features (fix: #15325)#15427
Open
puneetdixit200 wants to merge 1 commit into
Open
fix(cli): respect src/bin required-features (fix: #15325)#15427puneetdixit200 wants to merge 1 commit into
puneetdixit200 wants to merge 1 commit into
Conversation
Contributor
Package Changes Through a975472There are 2 changes which include tauri-cli with patch, tauri-bundler with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Legend-Master
approved these changes
May 22, 2026
Contributor
Legend-Master
left a comment
There was a problem hiding this comment.
Thanks!
Also you'll need to sign your commits for me to merge this
https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #15325.
get_binariesalready skips Cargo[[bin]]targets when theirrequired-featuresare not enabled. The latersrc/binscan did not know about those skipped manifest targets and added them back by filename.This keeps track of disabled manifest bins and skips matching
src/binentries, while still including them when the feature is enabled.Tests
cargo test --manifest-path crates/tauri-cli/Cargo.toml get_binaries_ignores_src_bin_with_disabled_required_features -- --nocapturecargo test --manifest-path crates/tauri-cli/Cargo.tomlcargo clippy --manifest-path crates/tauri-cli/Cargo.toml --all-targets --all-features -- -D warnings -A clippy::while_let_loopnode .scripts/ci/check-change-tags.js .changes/cli-required-features-src-bin.mdgit diff --checkNote: local Clippy 1.95 reports an existing
while_let_looplint inhelpers/pbxproj.rswithout that targeted allow.