fix(release): 固定 v1 镜像通道 - #540
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: QUIET Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟢 Approval recommended
The workflow and documentation updates are consistent with the stated v1 tagging policy change and appear correctly applied across the touched files.
Pull request overview
This PR adjusts the v1 release channel so v1 users pin to :1 and v1 releases no longer publish/update latest, while also updating documentation and compose examples to match the new tagging policy.
Changes:
- Restrict Docker publish workflow triggers to
v1.*tags and publish the stable v1 channel tag:1(withlatestdisabled). - Pin v1 Docker/Compose examples in README (EN/CN/JP) and
docker-compose.ymltoghcr.io/tbphp/gpt-load:1. - Update README download links to fetch
docker-compose.ymland.env.examplefrom thev1branch and clarify “latest v1” update wording.
File summaries
| File | Description |
|---|---|
| README.md | Pins Docker image to :1, updates config download links to v1, and clarifies v1 vs latest behavior. |
| README_CN.md | Same as README.md for Chinese documentation. |
| README_JP.md | Same as README.md for Japanese documentation. |
| docker-compose.yml | Pins the compose image tag to ghcr.io/tbphp/gpt-load:1. |
| .github/workflows/docker-build.yml | Limits workflow to v1.* tags and publishes the stable v1 channel tag :1 without latest. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a69ad0c22a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| services: | ||
| gpt-load: | ||
| image: ghcr.io/tbphp/gpt-load:latest | ||
| image: ghcr.io/tbphp/gpt-load:1 |
There was a problem hiding this comment.
Publish :1 before making it the default
For deployments made after this commit is merged but before the next stable v1 release, docker compose up will try to pull ghcr.io/tbphp/gpt-load:1 even though the commit description says that tag will only be created by that future release. This makes the newly documented quick-start and Compose installation fail during that interval; publish/backfill :1 before switching the default, or retain the existing tag until the release has completed.
Useful? React with 👍 / 👎.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
关联 Issue / Related Issue
N/A
变更内容 / Change Content
Bug 修复 / Bug fix
新功能 / New feature
其他改动 / Other changes
将 v1 Docker 发布工作流限制为
v1.*Tag;稳定发布生成:1,不再生成或更新latest将 v1 Compose 与三语言 README 的镜像示例固定为
ghcr.io/tbphp/gpt-load:1将 README 中已经失效的
main配置下载地址改为v1分支明确说明 v1 用户应固定使用
:1,而latest在过渡期后可能指向 v2本 PR 不创建 Tag、Release 或 Registry 标签。合并后由下一次稳定 v1 发布创建并更新
:1;现有latest保持原状。验证结果:
docker compose --env-file .env.example -f docker-compose.yml config --no-interpolate --quiet通过latest排除断言通过git diff --check通过Makefile不提供make check目标,因此未运行该命令自查清单 / Checklist
make check,或在说明中写明无法运行的原因和未验证范围。 / I ranmake check, or documented why it could not run and what remains unverified.