When support was added for resolving the DYLD_FRAMEWORK_PATH for the new jsc agent (#48), theWebKit/WebKitBuild string casing did not match the default casing when cloning the project with its current default name. See https://github.com/WebKit/webkit.
WebKit/WebKitBuild should be webkit/WebKitBuild and I had to make that change locally in order to resolve be able to update my DYLD_FRAMEWORK_PATH when running tests through jsc.
See code snippet below:
if (DYLD_FRAMEWORK_PATH === undefined) {
if (isSymlink.sync(this.hostPath)) {
let linked = fs.readlinkSync(this.hostPath);
if (linked.includes('WebKit/WebKitBuild')) {
DYLD_FRAMEWORK_PATH = path.dirname(linked);
}
} else {
if (this.hostPath.includes('WebKit/WebKitBuild')) {
DYLD_FRAMEWORK_PATH = path.dirname(this.hostPath);
}
}
}
I propose resolving this issue by making the string match case insensitive for either just thewebkit or the full string, or better yet just match on /WebKitBuild/ to avoid issues around renaming the top level project directory.
Thoughts? @rwaldron @bterlson
When support was added for resolving the DYLD_FRAMEWORK_PATH for the new jsc agent (#48), the
WebKit/WebKitBuildstring casing did not match the default casing when cloning the project with its current default name. See https://github.com/WebKit/webkit.WebKit/WebKitBuildshould bewebkit/WebKitBuildand I had to make that change locally in order to resolve be able to update my DYLD_FRAMEWORK_PATH when running tests through jsc.See code snippet below:
I propose resolving this issue by making the string match case insensitive for either just the
webkitor the full string, or better yet just match on/WebKitBuild/to avoid issues around renaming the top level project directory.Thoughts? @rwaldron @bterlson