NodeAgent: Execute scripts in dedicated VM#28
Conversation
|
@bterlson I've added a test for cross-realm interactions as per your request in IRC. Note that it does not assert error names. This vagueness is intentional because not all hosts currently report the correct error, but that's a detail for Test262 to validate. |
| `).then(function(result) { | ||
| assert.equal(result.stderr, ''); | ||
| assert(result.stdout.match(/^okay\r?\n/m)); | ||
| });; |
There was a problem hiding this comment.
nit: extra ; and strange indent
| print($.evalScript('let eshost;').type); | ||
| print($.evalScript('let eshost;').type); | ||
| `) | ||
| .then(function(result) { |
There was a problem hiding this comment.
nit: all other tests are using arrow function syntax. This is not a blocker in any practical sense, but consistency is ideal.
There was a problem hiding this comment.
The file is largely inconsistent in this regard, but I'm happy to use arrows here if you prefer.
|
Thanks for the review, @rwaldron. It should be all set |
|
whoops, I conflicted this one with #30. @jugglinmike can you rebase? |
jugglinmike
force-pushed
the
defensive-node
branch
from
136a541 to
de4cc8e
Compare
|
@bterlson Sure. Rebased on (For posterity, the original version of this branch is available here). |
|
With the conflicts resolved, I will assume @bterlson is 👍 |
|
Thank you both! |
3 participants
No description provided.