Use only pre-es6 syntax in the node runtime#99
Merged
rwaldron merged 2 commits intotc39:masterfrom Jan 29, 2020
Merged
Conversation
To allow the harness to be used with very old versions of node that predate es6 support (like `node 0.10`). It used to be like this before tc39#41 seems like.
Contributor
|
I'm going to accept this and do a release of eshost v6.x.x, but then I'm going end support for non-LTS versions of Node.js. That change will be documented and come with a v7 release. |
Contributor
Author
|
Sorry, but uhhh on secondary inspection, I may have kinda missed a location where a shorthand needed to be expanded out when I actually made this PR (that's what I get for using the web UI) - namely here. Would you wanna publish another v6 release with a small patch to finish fixing the problem? This time I can confirm that that's the only thing left from testing locally, at least. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To allow the runtime to be used with very old versions of node that predate es6 support (like
node 0.10). It used to be like this before #41 and #28 which were by and large unrelated to explicitly dropping support for older hosts in the test runtime, seems like; so it'd be nice to still support them, IMO.