Thorough tests for all types' string parsers#3286
Merged
Conversation
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Feb 27, 2026
I've replaced these string parsing tests with more thorough snapshotting tests in proposal-temporal: tc39/proposal-temporal#3286 I'll run those against each implementation to find out any remaining implementation divergences, and add more targeted tests to test262 covering any that I find. But for the time being, it doesn't make sense to keep these here. Supersedes tc39#4286.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3286 +/- ##
=======================================
Coverage 97.39% 97.39%
=======================================
Files 22 22
Lines 10766 10766
Branches 1865 1865
=======================================
Hits 10486 10486
Misses 258 258
Partials 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ms2ger
approved these changes
Mar 2, 2026
Ms2ger
pushed a commit
to ptomato/test262
that referenced
this pull request
Mar 2, 2026
I've replaced these string parsing tests with more thorough snapshotting tests in proposal-temporal: tc39/proposal-temporal#3286 I'll run those against each implementation to find out any remaining implementation divergences, and add more targeted tests to test262 covering any that I find. But for the time being, it doesn't make sense to keep these here. Supersedes tc39#4286.
Ms2ger
pushed a commit
to tc39/test262
that referenced
this pull request
Mar 2, 2026
I've replaced these string parsing tests with more thorough snapshotting tests in proposal-temporal: tc39/proposal-temporal#3286 I'll run those against each implementation to find out any remaining implementation divergences, and add more targeted tests to test262 covering any that I find. But for the time being, it doesn't make sense to keep these here. Supersedes #4286.
Snapshot tests for millions of string inputs to each Temporal type's from() method, covering as many variations of the string format as possible.
ptomato
force-pushed
the
thorough-parsing-tests
branch
from
9d790fe to
16e92fb
Compare
jessealama
pushed a commit
to jessealama/test262
that referenced
this pull request
Mar 3, 2026
I've replaced these string parsing tests with more thorough snapshotting tests in proposal-temporal: tc39/proposal-temporal#3286 I'll run those against each implementation to find out any remaining implementation divergences, and add more targeted tests to test262 covering any that I find. But for the time being, it doesn't make sense to keep these here. Supersedes tc39#4286.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snapshot tests for millions of string inputs to each Temporal type's from() method, covering as many variations of the string format as possible.