Tests for NumericSeparatorLiteral. Closes gh-1051#1176
Merged
Conversation
leobalter
suggested changes
Aug 14, 2017
leobalter
left a comment
leobalter
left a comment
Member
There was a problem hiding this comment.
Just a few comments. The tests are good!
I love the file names, it took me less than a minute to read them properly.
One thing I imagined for this is something checking whitespaces including line terminators, like:
1
_
1on this case, the return of that - in an expression - is 1, and we can have _ with a defined accessor desc to verify the access.
what do you think? too weird?
| assert.sameValue(0b0_1, 0b01); | ||
| assert.sameValue(0b0_1, 0b01); | ||
| assert.sameValue(0b0_1, 0b01); | ||
| assert.sameValue(0b0_1, 0b01); |
|
|
||
| ---*/ | ||
|
|
||
| assert.sameValue(0b0_1, 0b01); |
Member
There was a problem hiding this comment.
isn't this the same as in test/language/literals/numeric/numeric-separator-literal-bil-bd-nsl-bd-one-of.js?
| assert.sameValue(1_8, 18); | ||
| assert.sameValue(1_9, 19); | ||
|
|
||
|
|
Member
There was a problem hiding this comment.
while you're fixing the other parts, you may want to remove this extra line.
|
|
||
| ---*/ | ||
|
|
||
| assert.sameValue(1_0, 10); |
Member
There was a problem hiding this comment.
this case already exists in other files. I don't mind, but if the idea is testing one of, it would nice to add more assertions in this same file for:
2_1, 2_3, 2_4...
3_1, 3_2, 3_4...
...
leobalter
approved these changes
Aug 14, 2017
leobalter
suggested changes
Aug 14, 2017
|
|
||
| /*--- | ||
| esid: prod-NumericLiteralSeparator | ||
| description: description: NumericLiteralSeparator may not appear adjacent to another NumericLiteralSeparator in a BinaryIntegerLiteral |
|
|
||
| /*--- | ||
| esid: prod-NumericLiteralSeparator | ||
| description: `.` DecimalDigit NumericLiteralSeparator DecimalDigit ExponentPart_opt |
Member
There was a problem hiding this comment.
wrap the value with quotes, otherwise the yaml will fail parsing
Member
There was a problem hiding this comment.
same for other cases here with
description: `
leobalter
reviewed
Aug 14, 2017
|
|
||
| /*--- | ||
| esid: prod-NumericLiteralSeparator | ||
| description: description: NumericLiteralSeparator may not appear adjacent to another NumericLiteralSeparator in a OctalIntegerLiteral |
Member
There was a problem hiding this comment.
this is a profound description
rwaldron
force-pushed
the
1051
branch
2 times, most recently
from
d6f022f to
e6b429c
Compare
Member
|
We've got a few frontmatter linting bugs. |
Member
|
Thanks for adding the stage 3 label, I thought it was already on Stage 3 and almost merged this. |
Contributor
Author
|
Fixes to frontmatter pushed |
leobalter
approved these changes
Aug 21, 2017
Member
|
@rwaldron can you open a new PR with these commits? I clicked the merge button too early. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.