Skip to content

Temporal: Update duration tests to cover the largest possible ms, µs, and ns values#4760

Merged
Ms2ger merged 1 commit intotc39:mainfrom
catamorphism:max-duration-nanoseconds
Dec 4, 2025
Merged

Temporal: Update duration tests to cover the largest possible ms, µs, and ns values#4760
Ms2ger merged 1 commit intotc39:mainfrom
catamorphism:max-duration-nanoseconds

Conversation

@catamorphism
Copy link
Copy Markdown
Contributor

@catamorphism catamorphism requested a review from a team as a code owner December 3, 2025 22:07
@catamorphism
Copy link
Copy Markdown
Contributor Author

Re: @ptomato's comment on the issue, "We do need to update tests such as https://github.com/tc39/test262/blob/main/test/built-ins/Temporal/Duration/prototype/round/out-of-range-when-converting-from-normalized-duration.js " -- I searched for tests mentioning MAX_SAFE_INTEGER and winnowed down from there, but it's possible I missed some relevant tests.

@Ms2ger Ms2ger force-pushed the max-duration-nanoseconds branch from ebe75dc to 59b1ba6 Compare December 4, 2025 11:31
@Ms2ger Ms2ger enabled auto-merge (rebase) December 4, 2025 11:31
@Ms2ger Ms2ger merged commit 45e9824 into tc39:main Dec 4, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarity on maximum Duration nanoseconds value

2 participants