Intl Era Monthcode: PlainYearMonth tests, part 2#4766
Merged
Conversation
Ms2ger
approved these changes
Dec 5, 2025
This commit copies all of the PlainDate.since and .until tests that would apply to PlainYearMonth, and adapts them where necessary.
Ms2ger
force-pushed
the
intl-era-monthcode-plainyearmonth-part2
branch
from
9a2907b to
2d1d93c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit copies all of the PlainDate
since()anduntil()tests that would apply to PlainYearMonth, and adapts them where necessary.To follow:
add(),subtract(). See #4762 for part 1.It's very large so most likely the best way to review it is spot-checking and searching for extraneous
day:properties.