[Temporal] Remove test/staging/Temporal/v8/calendar-date-until.js#4817
Merged
[Temporal] Remove test/staging/Temporal/v8/calendar-date-until.js#4817
Conversation
Ms2ger
reviewed
Jan 7, 2026
test/built-ins/Temporal/PlainDate/prototype/until/throws-with-time-units.js
Outdated
Show resolved
Hide resolved
test/built-ins/Temporal/PlainDate/prototype/until/throws-with-time-units.js
Outdated
Show resolved
Hide resolved
Comment on lines
+25
to
+30
| for (const largestUnit of units) { | ||
| for (const smallestUnit of units) { | ||
| assert.throws(RangeError, () => from.until(to, { largestUnit, smallestUnit }), | ||
| `Can't use ${largestUnit} and ${smallestUnit} as largestUnit and smallestUnit for PlainDate`); | ||
| assert.throws(RangeError, () => from.until(to, { smallestUnit, largestUnit }), | ||
| `Can't use ${smallestUnit} and ${largestUnit} as largestUnit and smallestUnit for PlainDate`); |
Contributor
There was a problem hiding this comment.
This isn't covered yet, but I don't think we need the two calls in the loop (unless you meant to do something different in the second one?)
If we keep it, please add the parallel test for since
Contributor
Author
There was a problem hiding this comment.
Added the parallel test for since in 40ad13f. The second call was supposed to swap smallestUnit and largestUnit -- I fixed it.
Contributor
There was a problem hiding this comment.
I still feel like I'm missing something. You're looping over the same units array twice, so you're getting each combination already.
Contributor
Author
There was a problem hiding this comment.
Ah, yeah, you're right. Removed the second call.
ptomato
approved these changes
Jan 19, 2026
test/built-ins/Temporal/PlainDate/prototype/since/throws-with-time-units.js
Outdated
Show resolved
Hide resolved
And move functionality into one existing test and one new test.
…time-units.js Co-authored-by: Philip Chimento <philip.chimento@gmail.com>
ptomato
force-pushed
the
v8-staging-calendar-date-until
branch
from
711d5e7 to
c6b08c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And move functionality into one existing test and one new test.