[object-rest] Add coverage for comma-after-rest-property - #5102
Merged
gibson042 merged 3 commits intoAug 7, 2026
Merged
Conversation
…-invalid.case It is redundant with src/dstr-assignment/array-rest-before-elision.case
This was referenced Aug 3, 2026
Open
bakkot
reviewed
Aug 6, 2026
| @@ -1,20 +0,0 @@ | |||
| // Copyright (C) 2015 the V8 project authors. All rights reserved. | |||
Member
There was a problem hiding this comment.
Presumably you should also delete the generated tests? Or am I not understanding how this works?
Member
Author
There was a problem hiding this comment.
They were removed; GitHub just rendered them as renames.
bakkot
approved these changes
Aug 6, 2026
bakkot
left a comment
bakkot
left a comment
Member
There was a problem hiding this comment.
LGTM other than comment.
Incidentally I know at least some projects had a related bug for function parameter lists (e.g. TypeScript), and I didn't immediately see any coverage for that either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e.g.,
let {...rest,} = obj;or({...rest,} = obj).Currently failed by engine262, GraalJS, Hermes, and Moddable XS.
Also performs some minor cleanup in src/dstr-assignment: