Report a clearer error when a transformer class is given - #71
Merged
Conversation
Giving a transformer class instead of an instance made the parser call create_instance() on the class itself, with the class description as the self argument, and failed with a confusing missing argument error. v2 and v3 now check that argument up front. Fixes #54. Signed-off-by: Thomas Calmant <thomas.calmant@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Giving a transformer class instead of an instance, i.e.
load(fd, MyTransformer)instead of
load(fd, MyTransformer()), made the parser callcreate_instance()on the class itself. The class description was then givenas the
selfargument, and the call failed with:which points at the internals of the parser instead of the call of the user.
v2andv3now check that argument up front and explain what to do:The check only rejects classes: transformers are duck-typed, so an instance
which does not inherit from
ObjectTransformeris still accepted, as before.Test plan
TestTransformersArgumentadded to the v2 and v3 test suites: it checksthat
load()andloads()both reject a class and that the message namesthe transformer, and that instances are still accepted, with and without
inheriting from
ObjectTransformer.Fixes #54