Skip to content

Security fixes - #283

Merged
tchapi merged 4 commits into
mainfrom
cc/security-fixes
Sep 6, 2026
Merged

Security fixes#283
tchapi merged 4 commits into
mainfrom
cc/security-fixes

Conversation

@tchapi

@tchapi tchapi commented Sep 6, 2026

Copy link
Copy Markdown
Owner
  • 馃敀 Fixed an ACL bypass in the DAV server: appending ?sabreAction=asset to a URL skipped every permission check, letting any authenticated user read other users' events, contacts and files, and letting anonymous clients overwrite existing objects. The shortcut is now limited to the browser plugin's assets on the DAV root
  • 馃敀 Empty passwords are now rejected by all authentication backends. With LDAP, an empty password was passed to ldap_bind, which some directories (notably Active Directory) treat as a successful anonymous bind, allowing a login as any user
  • 馃敀 Destructive actions in the admin dashboard are now protected against CSRF: deleting users, calendars and address books, sharing and revoking calendars, and managing delegates are now POST requests carrying a token, instead of plain GET links
  • 馃敀 The dashboard and the API now check that a calendar or address book belongs to the user in the URL before showing, editing, sharing or deleting it. Deleting a calendar that was shared with a user only removes that share and no longer touches the owner's calendar; a calendar can no longer be shared with its own owner
  • 馃悰 The API no longer deletes all of a user's subscriptions and inbox items when one calendar is deleted, and GET /api/v1/calendars/{userId} no longer fails for users who have a calendar subscription

@tchapi tchapi self-assigned this Sep 6, 2026
@tchapi tchapi added the enhancement New feature or request label Sep 6, 2026
@tchapi tchapi moved this to In Progress in Davis Roadmap Sep 6, 2026
@tchapi
tchapi merged commit 728d686 into main Sep 6, 2026
11 checks passed
@tchapi
tchapi deleted the cc/security-fixes branch September 6, 2026 21:01
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Davis Roadmap Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant