Change is_video_enabled to report only main stream#187
Merged
flacjacket merged 1 commit intotchellomello:masterfrom Sep 10, 2021
Merged
Change is_video_enabled to report only main stream#187flacjacket merged 1 commit intotchellomello:masterfrom
flacjacket merged 1 commit intotchellomello:masterfrom
Conversation
The current is_video_enabled function (and video_enabled property, by extension) will mix together the main and extra (sub) streams when determining the channel to use. As such, the property will report being disabled when the substream is disabled even if the main stream is enabled. Change the behavior of the video_enabled property here to only report the main stream status on the regular encode. Add parameters to the is_video_enabled function to allow the stream and type to be selected.
Collaborator
Author
|
This is related to home-assistant/core#55661 and should provide a fix for that issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current is_video_enabled function (and video_enabled property, by
extension) will mix together the main and extra (sub) streams when
determining the channel to use. As such, the property will report being
disabled when the substream is disabled even if the main stream is
enabled. Change the behavior of the video_enabled property here to only
report the main stream status on the regular encode. Add parameters to
the is_video_enabled function to allow the stream and type to be
selected.