Skip to content

Change is_video_enabled to report only main stream #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flacjacket merged 1 commit into from
Sep 10, 2021
Merged

Change is_video_enabled to report only main stream #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions src/amcrest/video.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,10 +183,19 @@ def set_smart_ir(self, value: bool, channel: int) -> str:
str_value = "false" if value else "true"
return self.set_video_in_option("InfraRed", str_value, channel=channel)

def is_video_enabled(self, channel: int) -> bool:
"""Return if any video stream enabled."""
def is_video_enabled(
self, channel: int, *, stream: str = "Main", stream_type: int = 0
) -> bool:
"""Return if given video stream enabled.

The stream should be either "Main" or "Extra". For the main stream,
the stream type selects if it should read regular (0), motion detection
(1), alarm (2), or emergency (3) encode settings. For the extra
stream, the stream type selects if it should read extra stream 1 (0) or
extra stream 2 (0) settings.
"""
is_enabled = utils.extract_audio_video_enabled(
"Video", self.encode_media
f"{stream}Format[{stream_type}].Video", self.encode_media
)
return is_enabled[channel]

Expand Down Expand Up @@ -220,7 +229,7 @@ def smart_ir(self, value: bool) -> str:

@property
def video_enabled(self) -> bool:
"""Return if any video stream enabled."""
"""Return if main video stream enabled."""
return self.is_video_enabled(channel=0)

@video_enabled.setter
Expand Down