fix(api-server): add auth headers to WebSocket proxy#10141
Merged
davidfirst merged 2 commits intomasterfrom Dec 31, 2025
Merged
fix(api-server): add auth headers to WebSocket proxy#10141davidfirst merged 2 commits intomasterfrom
davidfirst merged 2 commits intomasterfrom
Conversation
Forward authentication headers on WebSocket connections to cloud server using the proxyReqWs hook from http-proxy-middleware.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors WebSocket proxy configuration to add authentication headers by migrating from a manual server upgrade event handler to using the proxyReqWs hook provided by http-proxy-middleware. This approach aligns with how other proxies in the file (GraphQL and REST) are configured.
Key Changes:
- Removed manual WebSocket proxy handling using
http-proxy'screateProxyServerand server upgrade events - Implemented authentication header forwarding using the
proxyReqWshook withincreateProxyMiddlewareconfiguration - Cleaned up the
http-proxyimport that is no longer needed
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GiladShoham
approved these changes
Dec 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward authentication headers on WebSocket connections to cloud server using the
proxyReqWshook from http-proxy-middleware instead of manually handling server upgrade events.