fix: Missing Packages After bit new with Forked Env by zkochan · Pull Request #10201 · teambit/bit

zkochan · 2026-02-19T16:59:13Z

Two fixes for the chicken-and-egg problem where "+" dependency markers on a forked env couldn't resolve in a fresh workspace:

workspace-manifest-factory.ts: widen usedPeerDependencies filter to include packages explicitly listed in the component's dep-resolver config, so pnpm will install them even before they appear in the resolved dependency manifest.
apply-overrides.ts: in getDependenciesToAddManually(), when _manuallyAddPackage() can't resolve "+" from workspace package.json, check if the package was already resolved by applyAutoDetectedPeersFromEnvOnEnvItSelf() and remove it from missingPackageDependencies to prevent a false MissingManuallyConfiguredPackages issue.

Proposed Changes

…egression) Reproduces the chicken-and-egg problem where forking an env with "+" dep-resolver entries into a fresh workspace causes MissingManuallyConfiguredPackages because the usedPeerDependencies filter excludes packages that aren't yet installed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Two fixes for the chicken-and-egg problem where "+" dependency markers on a forked env couldn't resolve in a fresh workspace: 1. workspace-manifest-factory.ts: widen usedPeerDependencies filter to include packages explicitly listed in the component's dep-resolver config, so pnpm will install them even before they appear in the resolved dependency manifest. 2. apply-overrides.ts: in getDependenciesToAddManually(), when _manuallyAddPackage() can't resolve "+" from workspace package.json, check if the package was already resolved by applyAutoDetectedPeersFromEnvOnEnvItSelf() and remove it from missingPackageDependencies to prevent a false MissingManuallyConfiguredPackages issue. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Copilot

Pull request overview

Fixes a regression where a fresh workspace created via bit new / bit fork with a forked env can end up with manually-configured "+" dependencies never getting installed (and repeatedly reported as missing), by ensuring those deps make it into the generated manifests and by reducing a related false-positive missing-deps report.

Changes:

Include env peer-deps in usedPeerDependencies when the package is explicitly present in the component’s dep-resolver policy (to break the "+" chicken-and-egg cycle).
Avoid reporting MissingManuallyConfiguredPackages when a + sentinel can’t be resolved but the package is already present in resolved package dependencies.
Add an e2e regression test covering the forked-env + marker scenario.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
`scopes/dependencies/dependency-resolver/manifest/workspace-manifest-factory.ts`	Expands the `usedPeerDependencies` filter to also consider explicitly-configured dep-resolver policy packages.
`scopes/dependencies/dependencies/dependencies-loader/apply-overrides.ts`	Removes a dependency from `missingPackageDependencies` when it’s already present in resolved package deps.
`e2e/harmony/dependencies/forked-env-missing-deps.e2e.ts`	Adds regression coverage for the forked-env `+` dependency marker installation cycle.

scopes/dependencies/dependency-resolver/manifest/workspace-manifest-factory.ts

scopes/dependencies/dependencies/dependencies-loader/apply-overrides.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

e2e/harmony/dependencies/forked-env-missing-deps.e2e.ts

scopes/dependencies/dependencies/dependencies-loader/apply-overrides.ts

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

scopes/dependencies/dependency-resolver/manifest/workspace-manifest-factory.ts

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Copilot · 2026-02-26T18:03:25Z

scopes/dependencies/dependency-resolver/manifest/workspace-manifest-factory.ts

+  private getComponentExplicitPackages(component: Component): Set<string> {
+    const depResolverEntry = component.get(DependencyResolverAspect.id);
+    const explicitPolicy = depResolverEntry?.config?.policy ?? {};
+    return new Set<string>([
+      ...nonRemovedEntryNames(explicitPolicy.dependencies),
+      ...nonRemovedEntryNames(explicitPolicy.devDependencies),
+      ...nonRemovedEntryNames(explicitPolicy.peerDependencies),
+    ]);
+
+    function nonRemovedEntryNames(policySection?: Record<string, VariantPolicyConfigEntryValue>): string[] {
+      if (!policySection) return [];
+      const names: string[] = [];
+      for (const [name, versionSpec] of Object.entries(policySection)) {
+        // Skip explicit removals expressed as "-" or as removal objects.
+        if (versionSpec !== '-' && !isRemovalObject(versionSpec)) {


In getComponentExplicitPackages(), the helper functions (nonRemovedEntryNames / isRemovalObject) are declared after the return statement. Although function declarations are hoisted, this layout is easy to misread as unreachable/dead code and can confuse future maintenance. Consider moving the helper function declarations above the return, or extracting them to private static methods outside this function.

Copilot · 2026-02-26T18:03:25Z

scopes/dependencies/dependency-resolver/manifest/workspace-manifest-factory.ts

+      return names;
+    }
+
+    function isRemovalObject(val: VariantPolicyConfigEntryValue): val is VariantPolicyEntryValue {


isRemovalObject() is typed as a type guard returning val is VariantPolicyEntryValue, but it checks val.version === '-'. VariantPolicyEntryValue.version is typed as a semver string, so this guard is semantically inconsistent and may mislead TypeScript narrowing. Consider changing the guard to match the actual removal-object shape (e.g. val is { version: '-' }) or avoid the type predicate and just do a runtime check for a version field equal to '-'.

Suggested change

function isRemovalObject(val: VariantPolicyConfigEntryValue): val is VariantPolicyEntryValue {

function isRemovalObject(val: VariantPolicyConfigEntryValue): boolean {

zkochan and others added 3 commits February 19, 2026 17:57

style: fix

e4ed040

zkochan marked this pull request as ready for review February 19, 2026 19:06

Copilot AI review requested due to automatic review settings February 19, 2026 19:06

Copilot started reviewing on behalf of zkochan February 19, 2026 19:07 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

scopes/dependencies/dependency-resolver/manifest/workspace-manifest-factory.ts Outdated Show resolved Hide resolved

scopes/dependencies/dependencies/dependencies-loader/apply-overrides.ts Outdated Show resolved Hide resolved

zkochan and others added 2 commits February 20, 2026 15:45

Merge branch 'master' into fix/10200

5d83398

Apply suggestion from @Copilot

7075933

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 20, 2026 15:52

Copilot started reviewing on behalf of zkochan February 20, 2026 15:53 View session

Apply suggestion from @Copilot

b82b39f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI reviewed Feb 20, 2026

View reviewed changes

zkochan added 2 commits February 23, 2026 02:36

fix: compile

10ee224

Merge branch 'master' into fix/10200

5d4a025

Copilot AI review requested due to automatic review settings February 24, 2026 08:14

Copilot started reviewing on behalf of zkochan February 24, 2026 08:15 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

e2e/harmony/dependencies/forked-env-missing-deps.e2e.ts Show resolved Hide resolved

scopes/dependencies/dependencies/dependencies-loader/apply-overrides.ts Outdated Show resolved Hide resolved

zkochan added 2 commits February 24, 2026 09:51

refactor: workspace manifest factory

99ed48e

refactor: pr

fe0c1d7

Copilot AI review requested due to automatic review settings February 24, 2026 11:11

Copilot started reviewing on behalf of zkochan February 24, 2026 11:12 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

scopes/dependencies/dependency-resolver/manifest/workspace-manifest-factory.ts Outdated Show resolved Hide resolved

scopes/dependencies/dependency-resolver/manifest/workspace-manifest-factory.ts Outdated Show resolved Hide resolved

zkochan added 2 commits February 24, 2026 13:29

fix: comment

f61e377

Merge branch 'master' into fix/10200

819675d

Copilot AI review requested due to automatic review settings February 26, 2026 17:56

Copilot started reviewing on behalf of zkochan February 26, 2026 17:56 View session

Copilot AI reviewed Feb 26, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Missing Packages After bit new with Forked Env#10201

fix: Missing Packages After bit new with Forked Env#10201
zkochan wants to merge 12 commits intoteambit:masterfrom
zkochan:fix/10200

zkochan commented Feb 19, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 26, 2026

Uh oh!

Copilot AI Feb 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	function isRemovalObject(val: VariantPolicyConfigEntryValue): val is VariantPolicyEntryValue {
	function isRemovalObject(val: VariantPolicyConfigEntryValue): boolean {

Conversation

zkochan commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

zkochan commented Feb 19, 2026 •

edited

Loading