fix(workspace): improve config-merger log message readability#10235
Merged
davidfirst merged 3 commits intomasterfrom Mar 18, 2026
Merged
fix(workspace): improve config-merger log message readability#10235davidfirst merged 3 commits intomasterfrom
davidfirst merged 3 commits intomasterfrom
Conversation
Replace abbreviated "ws" and "comp" with full words "workspace" and "the component" in dependency update log messages.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates user-facing log messages emitted by the workspace config merger when deciding whether to update, conflict, or skip dependency version changes in workspace.jsonc.
Changes:
- Rephrases “ws/comp” wording to “workspace/component” for clarity in several “not updating” log reasons.
- Adjusts some messages around “min version” / “range” scenarios to be more descriptive.
You can also share your feedback on Copilot code review. Take the survey.
- Use "workspace range" instead of "workspace version" when depInWsVer is a range - Include computed wsMinVer in log message for clarity
GiladShoham
approved these changes
Mar 18, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines user-facing log messages emitted by the workspace config merger when deciding whether to update dependency versions/ranges in workspace.jsonc, making the output more explicit about “workspace” vs “component”.
Changes:
- Reworded “not updating” log messages for dependency version/range comparisons.
- Added more detailed context to one log message by including the computed min version for a workspace range.
You can also share your feedback on Copilot code review. Take the survey.
| return; | ||
| } | ||
| addNotUpdateToLogs(`the version from ws ${depInWsVer} is greater than ${depInCompVer} from comp`); | ||
| addNotUpdateToLogs(`the workspace version ${depInWsVer} is greater than ${depInCompVer} from the component`); |
| return; | ||
| } | ||
| addNotUpdateToLogs(`the range from ws ${depInWsVer} is greater than ${depInCompVer} from comp`); | ||
| addNotUpdateToLogs(`the workspace range ${depInWsVer} is greater than ${depInCompVer} from the component`); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace abbreviated "ws" and "comp" with full words "workspace" and "the component" in dependency update log messages for better readability.
Before:
@teambit/defender.eslint-linter - not updating. the version from ws 1.0.60 is greater than 1.0.59 from compAfter:
@teambit/defender.eslint-linter - not updating. the workspace version 1.0.60 is greater than 1.0.59 from the component