fix(reset): simplify compact usage and rewrite e2e test for clarity#10273
Merged
davidfirst merged 4 commits intomasterfrom Apr 6, 2026
Merged
fix(reset): simplify compact usage and rewrite e2e test for clarity#10273davidfirst merged 4 commits intomasterfrom
davidfirst merged 4 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Follow-up cleanup to the bit reset lane-history fix from #10270: it improves readability of batchId extraction during reset, and simplifies the related e2e test narrative to make the snap → reset → snap flow easier to follow.
Changes:
- Refactors batchId collection to a clearer two-step
compact()flow when loading version objects during reset. - Rewrites the lane history-diff e2e scenario naming/documentation to use “snap A/B/C” labels and updated assertions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scopes/component/snapping/reset-component.ts | Improves readability of batchId extraction by separating version-object compaction from batchId compaction. |
| e2e/harmony/lanes/lane-history-diff.e2e.ts | Renames/re-documents the snap/reset flow and updates assertions for the “no orphaned lane-history entry after reset” scenario. |
GiladShoham
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #10270.
compact(compact(versionObjects).map(...))with a clearer two-step: firstcompactto filter missing version objects, thencompacton the mapped batchIds