Skip to content

fix(reset): simplify compact usage and rewrite e2e test for clarity#10273

Merged
davidfirst merged 4 commits intomasterfrom
fix/reset-lane-history-cleanup-followup
Apr 6, 2026
Merged

fix(reset): simplify compact usage and rewrite e2e test for clarity#10273
davidfirst merged 4 commits intomasterfrom
fix/reset-lane-history-cleanup-followup

Conversation

@davidfirst
Copy link
Copy Markdown
Member

Follow-up to #10270.

  • Replace compact(compact(versionObjects).map(...)) with a clearer two-step: first compact to filter missing version objects, then compact on the mapped batchIds
  • Rewrite the e2e test doc and naming to use simple A/B/C labels instead of "local snap"/"first snap"/"final snap" — makes the snap→reset→snap flow easier to follow

Copilot AI review requested due to automatic review settings April 6, 2026 13:32
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Follow-up cleanup to the bit reset lane-history fix from #10270: it improves readability of batchId extraction during reset, and simplifies the related e2e test narrative to make the snap → reset → snap flow easier to follow.

Changes:

  • Refactors batchId collection to a clearer two-step compact() flow when loading version objects during reset.
  • Rewrites the lane history-diff e2e scenario naming/documentation to use “snap A/B/C” labels and updated assertions.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
scopes/component/snapping/reset-component.ts Improves readability of batchId extraction by separating version-object compaction from batchId compaction.
e2e/harmony/lanes/lane-history-diff.e2e.ts Renames/re-documents the snap/reset flow and updates assertions for the “no orphaned lane-history entry after reset” scenario.

Comment thread e2e/harmony/lanes/lane-history-diff.e2e.ts Outdated
Comment thread e2e/harmony/lanes/lane-history-diff.e2e.ts
Copilot AI review requested due to automatic review settings April 6, 2026 15:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@davidfirst davidfirst enabled auto-merge (squash) April 6, 2026 16:27
@davidfirst davidfirst merged commit c9a1fd6 into master Apr 6, 2026
12 checks passed
@davidfirst davidfirst deleted the fix/reset-lane-history-cleanup-followup branch April 6, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants